Skip to content

cmake: enable SOVERSION for Cygwin and CMAKE_DLL_NAME_WITH_SOVERSION #13898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

cmake: enable SOVERSION for Cygwin and CMAKE_DLL_NAME_WITH_SOVERSION #13898

wants to merge 2 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jun 5, 2024 •
edited
Loading

@vszakats vszakats added the cmake label Jun 5, 2024
@github-actions github-actions bot added the build label Jun 5, 2024
@vszakats vszakats mentioned this pull request Jun 5, 2024
Merged
@github-actions github-actions bot added the CI Continuous Integration label Jun 10, 2024
@vszakats
Copy link
Member Author

vszakats commented Jun 11, 2024 •
edited
Loading

Unrelated observation: in MSYS2 native builds, autotools creates msys-curl-4.dll, while cmake sticks with libcurl-4.dll. This seems to be coming from autotools itself, but I'm not sure. Another challenge would be detecting MSYS native builds in CMake. This PR is not trying to sync up this behaviour.

vszakats added a commit to vszakats/curl that referenced this pull request Jun 13, 2024
@vszakats
cmake: stop setting SOVERSION for the static lib target
9ab2ad9 
Cherry-picked from curl#13898
Closes #xxxxx
@vszakats vszakats mentioned this pull request Jun 13, 2024
Closed
vszakats added a commit that referenced this pull request Jun 13, 2024
@vszakats
cmake: stop setting SOVERSION for the static lib target
831047f 
Also move the logic closer to its use and related tidy-ups.

Cherry-picked from #13898
Closes #13936
@vszakats vszakats removed the CI Continuous Integration label Jun 13, 2024
@vszakats vszakats changed the title cmake: allow more control for libcurl SOVERSION cmake: allow SOVERSION override, enable for Cygwin and CMAKE_DLL_NAME_WITH_SOVERSION Jun 13, 2024
@vszakats vszakats mentioned this pull request Jun 13, 2024
Closed
vszakats added a commit that referenced this pull request Jun 13, 2024
@vszakats
cmake: allow SOVERSION override with CURL_LIBCURL_SOVERSION
bd2d5db 
Allow overriding SOVERSION with the new CMake option:
`CURL_LIBCURL_SOVERSION=ON/OFF`

For certain target platforms the shared libcurl library filename
contains the SOVERSION. This new option allows to enable/disable
this behavior manually. If set, it takes precedence over the default
setting.

Ref: #13898
Closes #13944
@vszakats vszakats changed the title cmake: allow SOVERSION override, enable for Cygwin and CMAKE_DLL_NAME_WITH_SOVERSION cmake: enable SOVERSION for Cygwin and CMAKE_DLL_NAME_WITH_SOVERSION Jun 13, 2024
@vszakats vszakats closed this in e5a35b4 Jun 13, 2024
@vszakats vszakats deleted the dll-soversion branch June 13, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vszakats