Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool_writeout: bsearch the variable name #13914

Closed
wants to merge 5 commits into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Jun 10, 2024

As the list of variable names grows, doing a simple loop to find the name get increasingly worse. This switches to a bsearch.

Also: do a case sensitive check for the variable name. The names have not been documented to be case insensitive and there is no point in having them so.

Bonus: only get the CERTINFO data when actually needed

As the list of variable names grows, doing a simple loop to find the
name get increasingly worse. This switches to a bsearch.

Also: do a case sensitive check for the variable name. The names have
not been documented to be case insensitive and there is no point in
having them so.
@github-actions github-actions bot added the tests label Jun 10, 2024
@bagder bagder closed this in 4464c9f Jun 10, 2024
bagder added a commit that referenced this pull request Jun 10, 2024
Removes a fairly expensive libcurl call when not necessary

Closes #13914
@bagder bagder deleted the bagder/writeout-bsearch branch June 10, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant