New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schannel: fix compiler warnings #1394

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@MarcelRaad
Member

MarcelRaad commented Apr 6, 2017

When UNICODE is not defined, the Curl_convert_UTF8_to_tchar macro maps
directly to its argument. As it is declared as a pointer to const and
InitializeSecurityContext expects a pointer to non-const, both MSVC and MinGW
issue a warning about implicitly casting away the const. Fix this by declaring
the variables as pointers to non-const.

schannel: fix compiler warnings
When UNICODE is not defined, the Curl_convert_UTF8_to_tchar macro maps
directly to its argument. As it is declared as a pointer to const and
InitializeSecurityContext expects a pointer to non-const, both MSVC and MinGW
issue a warning about implicitly casting away the const. Fix this by declaring
the variables as pointers to non-const.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 6, 2017

@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mback2k, @masali-hp and @jay to be potential reviewers.

mention-bot commented Apr 6, 2017

@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mback2k, @masali-hp and @jay to be potential reviewers.

@jay

jay approved these changes Apr 6, 2017

before sending this upstream please amend to the commit message a blank line followed by a Ref: or a Closes to this PR

@MarcelRaad MarcelRaad closed this in 33ca733 Apr 7, 2017

@MarcelRaad MarcelRaad deleted the MarcelRaad:schannel_warnings branch Apr 7, 2017

@MarcelRaad

This comment has been minimized.

Show comment
Hide comment
@MarcelRaad

MarcelRaad Apr 7, 2017

Member

Thanks!

Member

MarcelRaad commented Apr 7, 2017

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.