sspi: print out InitializeSecurityContext() error message #1395
Conversation
|
@Frenche, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @bagder and @mirekfranc to be potential reviewers. |
There was a problem hiding this comment.
I don't think See is a parseable keyword, when you are referencing a bug please use Bug: or if it's a github issue you could use one of the github auto keywords instead like Fixes. hre are some examples, check the repo history for more
-- blank line --
Bug: https://github.com/curl/curl/issues/1384
Reported-by: Carsten (talksinmath)
Closes #1395
Reported-by: Carsten (talksinmath)
Fixes https://github.com/curl/curl/issues/1384
Closes https://github.com/curl/curl/pull/1395
Reported-by: Carsten (talksinmath)
Fixes #1384
Closes #1395
It looks like it returns that for all errors that contain 0x80000000 or in other words all SEC_E_ errors. I can't think of a good catch all there, maybe CURLE_RECV_ERROR |
|
I think OOM is used as a generic error. |
| @@ -224,6 +225,8 @@ CURLcode Curl_auth_decode_spnego_message(struct Curl_easy *data, | |||
| free(chlg); | |||
|
|
|||
| if(GSS_ERROR(nego->status)) { | |||
| failf(data, "InitializeSecurityContext failed: %s", | |||
| Curl_sspi_strerror(data->easy_conn, nego->status)); | |||
| return CURLE_OUT_OF_MEMORY; | |||
There was a problem hiding this comment.
I'm with @jay, CURLE_RECV_ERROR might be slightly better. But none of them is ideal here...
I think it's ok because Curl_auth_decode_spnego_message() is called from Curl_input_negotiate() which is called with 'conndata' (assuming conn->data->easy_conn is circular). |
|
yes it's fine |
|
I've updated the commit message. Thanks all for the reviews. |
|
LGTM |
Signed-off-by: Isaac Boukris iboukris@gmail.com
Assisted-by: Jay Satiro
Reported-by: Carsten (talksinmath)
See #1384