Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix quotes when appending multiple options (SecureTransport) #13953

Closed
wants to merge 1 commit into from

Conversation

@vszakats vszakats added cmake appleOS specific to an Apple operating system labels Jun 14, 2024
@github-actions github-actions bot added the build label Jun 14, 2024
@vszakats vszakats changed the title cmake: fix quotes when appending two values cmake: fix quotes when appending multiple values (SecureTransport) Jun 14, 2024
@vszakats vszakats changed the title cmake: fix quotes when appending multiple values (SecureTransport) cmake: fix quotes when appending multiple options (SecureTransport) Jun 14, 2024
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But "Closes" probably shouldn't point to the PR?

IIRC the background is cmake dependency handling in meson. But that is still a long way to go. (Transitive dependencies, static linkage, splattered over multiple PRs.)

@bagder
Copy link
Member

bagder commented Jun 15, 2024

@vszakats
Copy link
Member Author

"Closes" makes this PR closed when including it the final commit message.

I'm rooting for GitHub to recognize a Merged #<PR> tag.

@vszakats vszakats closed this in b37040d Jun 15, 2024
@vszakats vszakats deleted the cmake-fix-quotes branch July 9, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appleOS specific to an Apple operating system build cmake
Development

Successfully merging this pull request may close these issues.

None yet

3 participants