Fix unreachable code warning in test for windows msvc compilation#13967
Closed
talregev wants to merge 1 commit intocurl:masterfrom
Closed
Fix unreachable code warning in test for windows msvc compilation#13967talregev wants to merge 1 commit intocurl:masterfrom
talregev wants to merge 1 commit intocurl:masterfrom
Conversation
bagder
added a commit
that referenced
this pull request
Jun 19, 2024
Since the framework is already returning that variable by default. Avoids a warning for unreachable code. Fixes #13967
Member
|
I propose #13973 instead. |
Contributor
Author
|
Thank you for your fix. I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After run vcpkg-windows ci with openssl build option, I found this compilation error:
I fix the test.