Skip to content

Fix unreachable code warning in test for windows msvc compilation #13967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix unreachable code warning in test for windows msvc compilation #13967

wants to merge 1 commit into from

Conversation

talregev
Copy link
Contributor

After run vcpkg-windows ci with openssl build option, I found this compilation error:

D:\a\curl\curl\tests\unit\unit2604.c(111) : error C2220: the following warning is treated as an error
D:\a\curl\curl\tests\unit\unit2604.c(111) : warning C4702: unreachable code

I fix the test.

@github-actions github-actions bot added the tests label Jun 18, 2024
bagder added a commit that referenced this pull request Jun 19, 2024
@bagder
unit2604: use 'unitfail' instead of 'error' variable
02bb066 
Since the framework is already returning that variable by default.
Avoids a warning for unreachable code.

Fixes #13967
@bagder bagder mentioned this pull request Jun 19, 2024
Closed
@bagder
Copy link
Member

bagder commented Jun 19, 2024

I propose #13973 instead.

@talregev
Copy link
Contributor Author

Thank you for your fix. I will close this PR.

@talregev talregev closed this Jun 19, 2024
bagder added a commit that referenced this pull request Jun 19, 2024
@bagder
unit2604: use 'unitfail' instead of 'error' variable
df2fbc2 
Since the framework is already returning that variable by default.
Avoids a warning for unreachable code.

Reported-by: Tal Regev
Fixes #13967
Closes #13973
@talregev talregev deleted the TalR/fix_test_for_windows branch June 21, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talregev @bagder