Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfssl: add support for ssl cert blob / ssl key blob options #14018

Closed
wants to merge 1 commit into from

Conversation

alexsn
Copy link

@alexsn alexsn commented Jun 25, 2024

wolfSSL supports setting certificates/private keys from memory blobs which allow us to implement both CURLOPT_SSLCERT_BLOB and CURLOPT_SSLKEY_BLOB options.

@github-actions github-actions bot added the TLS label Jun 25, 2024
docs/libcurl/opts/CURLOPT_SSLCERT_BLOB.md Outdated Show resolved Hide resolved
docs/libcurl/opts/CURLOPT_SSLKEY_BLOB.md Outdated Show resolved Hide resolved
@alexsn alexsn force-pushed the wolfssl_client_cert_from_blob branch from 0c3f49a to 9f0125f Compare June 25, 2024 17:15
@bagder bagder added the feature-window A merge of this requires an open feature window label Jun 26, 2024
@bagder
Copy link
Member

bagder commented Jun 26, 2024

We qualify this as a change (not bugfix), which means it needs to wait for the feature window to open before we can merge it. These options will therefore not be supported with wolfSSL in 8.9.0 but most likely in 8.10.0.

@alexsn
Copy link
Author

alexsn commented Jun 26, 2024

We qualify this as a change (not bugfix), which means it needs to wait for the feature window to open before we can merge it. These options will therefore not be supported with wolfSSL in 8.9.0 but most likely in 8.10.0.

Should I update this pull request to say 8.10.0 in the docs?

@bagder
Copy link
Member

bagder commented Jun 26, 2024

Should I update this pull request to say 8.10.0 in the docs?

Yes please!

@alexsn alexsn force-pushed the wolfssl_client_cert_from_blob branch from 9f0125f to 5af8204 Compare June 26, 2024 14:06
@bagder bagder self-assigned this Jun 30, 2024
@bagder
Copy link
Member

bagder commented Aug 3, 2024

@alexsn can you please fix the merge conflicts in the docs and force-push?

@alexsn alexsn force-pushed the wolfssl_client_cert_from_blob branch 3 times, most recently from 001a5ad to 6ada270 Compare August 4, 2024 06:40
wolfSSL supports setting certificates/private keys from memory
blobs which allow us to implement both CURLOPT_SSLCERT_BLOB and
CURLOPT_SSLKEY_BLOB options.
@alexsn alexsn force-pushed the wolfssl_client_cert_from_blob branch from 6ada270 to 9053cd7 Compare August 4, 2024 06:45
@bagder bagder closed this in 8d98118 Aug 5, 2024
@bagder
Copy link
Member

bagder commented Aug 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-window A merge of this requires an open feature window TLS
Development

Successfully merging this pull request may close these issues.

2 participants