Skip to content

system_win32: add missing curl.h include #14019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

system_win32: add missing curl.h include #14019

wants to merge 1 commit into from

Conversation

MarcelRaad
Copy link
Member

It's required for CURLcode.

@github-actions github-actions bot added the Windows Windows-specific label Jun 25, 2024
@MarcelRaad
system_win32: add missing curl.h include
1bc86c3 
It's required for `CURLcode`.

Closes curl#14019
@MarcelRaad MarcelRaad force-pushed the system_win32_missing_curl_include branch from 053960e to 1bc86c3 Compare June 25, 2024 19:11
@bagder
Copy link
Member

bagder commented Jun 26, 2024

It's required for CURLcode.

Did this cause a build problem somewhere?

@MarcelRaad
Copy link
Member Author

Yes, it shows up in both of my autobuild runners:
https://curl.se/dev/log.cgi?id=20240626040432-3047891#prob1
Probably because of the --disable-socketpair as socketpair.h is the only include before system_win32.h in

curl/lib/asyn-thread.c

Line 57 in 72abf7c

#include "system_win32.h"
.

@MarcelRaad MarcelRaad deleted the system_win32_missing_curl_include branch June 26, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcelRaad @bagder