Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update dependency cloudflare/quiche to v0.22.0 #14030

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 26, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
cloudflare/quiche minor 0.21.0 -> 0.22.0

Release Notes

cloudflare/quiche (cloudflare/quiche)

v0.22.0: πŸ”§ 0.22.0

Compare Source

Breaking Changes:

  • The quiche_conn_stream_recv() and quiche_conn_stream_send() FFI functions now take an additional parameter out_error_code used to return more specific error information to the caller (similarly to what the Rust API already does).

Highlights:

  • Added number of acked bytes to the Stats structure.
  • The libquiche.so library, that exposes FFI bindings for C, will now have SONAME information.
  • Added configuration option to change the anti-amplification limit factor (default will still be "3", per RFC 9000).
  • Many more bug fixes and performance improvements.

Full changelog at cloudflare/quiche@0.21.0...0.22.0


Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the CI Continuous Integration label Jun 26, 2024
@renovate renovate bot force-pushed the renovate/cloudflare-quiche-0.x branch from 9a66021 to 98f0136 Compare June 27, 2024 21:16
@bagder bagder added the HTTP/3 h3 or quic related label Jun 27, 2024
@bagder
Copy link
Member

bagder commented Jun 27, 2024

This fails to build:

/usr/bin/ld: warning: libquiche.so.0, needed by ../lib/.libs/libcurl.so, not found (try using -rpath or -rpath-link)

When I build quiche 0.22.0 locally on my Debian machine, I get these files:

$ ls -l target/release/libquiche.*
-rw-rw-r-- 2 dast dast 102407402 Jun 27 23:35 target/release/libquiche.a
-rw-r--r-- 1 dast dast      3185 Jun 27 23:35 target/release/libquiche.d
-rw-rw-r-- 2 dast dast  59128356 Jun 27 23:35 target/release/libquiche.rlib
-rwxrwxr-x 2 dast dast  33709688 Jun 27 23:35 target/release/libquiche.so

So no libquiche.so.0 is present. Where does the .0 come from?

Look:

$ readelf -a target/release/libquiche.so | grep SONAME
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]

@bagder
Copy link
Member

bagder commented Jun 27, 2024

Seems related to this: cloudflare/quiche#1769

quiche 0.22.0 will set SONAME in libquiche.so (libquiche.so.0) for
linux/BSDs. Install a symlink with SONAME.
@junhochoi
Copy link
Contributor

Seems related to this: cloudflare/quiche#1769

Looks like it. I tried to make a PR on top of this branch to fix it by installing a symlink.
Working on my dev.

#14046

@junhochoi
Copy link
Contributor

junhochoi commented Jun 28, 2024

So no libquiche.so.0 is present. Where does the .0 come from?

https://github.com/lu-zero/cdylib-link-lines/blob/master/src/lib.rs#L61

would explain why.

Copy link
Contributor Author

renovate bot commented Jun 28, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@ghedo
Copy link
Contributor

ghedo commented Jun 28, 2024

Why not just link to libquiche statically though? We already do it for BoringSSL.

@bagder
Copy link
Member

bagder commented Jun 28, 2024

No reason really. There's no real preference and it worked fine to use the shared version so we had no reason to do it differently...

@bagder bagder closed this in ad7a20d Jun 28, 2024
@bagder bagder deleted the renovate/cloudflare-quiche-0.x branch June 28, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration HTTP/3 h3 or quic related
Development

Successfully merging this pull request may close these issues.

None yet

3 participants