-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
ci: Update dependency cloudflare/quiche to v0.22.0 #14030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9a66021
to
98f0136
Compare
This fails to build:
When I build quiche 0.22.0 locally on my Debian machine, I get these files:
So no Look:
|
Seems related to this: cloudflare/quiche#1769 |
quiche 0.22.0 will set SONAME in libquiche.so (libquiche.so.0) for linux/BSDs. Install a symlink with SONAME.
Looks like it. I tried to make a PR on top of this branch to fix it by installing a symlink. |
https://github.com/lu-zero/cdylib-link-lines/blob/master/src/lib.rs#L61 would explain why. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Why not just link to libquiche statically though? We already do it for BoringSSL. |
No reason really. There's no real preference and it worked fine to use the shared version so we had no reason to do it differently... |
This PR contains the following updates:
0.21.0
->0.22.0
Release Notes
cloudflare/quiche (cloudflare/quiche)
v0.22.0
: 🔧 0.22.0Compare Source
Breaking Changes:
quiche_conn_stream_recv()
andquiche_conn_stream_send()
FFI functions now take an additional parameterout_error_code
used to return more specific error information to the caller (similarly to what the Rust API already does).Highlights:
Stats
structure.libquiche.so
library, that exposes FFI bindings for C, will now have SONAME information.Full changelog at cloudflare/quiche@0.21.0...0.22.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.