Skip to content

curl: list categories in --help #14055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

curl: list categories in --help #14055

wants to merge 2 commits into from

Conversation

dfandrich
Copy link
Contributor

This eliminates the need to run an extra help subcommand to get the
possible categories, reducing the friction in getting relevant help. The
help wording was also slightly tweaked for grammatical accuracy.

Closes #14055

dfandrich added a commit that referenced this pull request Jun 28, 2024
@dfandrich
curl: list categories in --help
c272de9 
This eliminates the need to run an extra help subcommand to get the
possible categories, reducing the friction in getting relevant help. The
help wording was also slightly tweaked for grammatical accuracy.

Closes #14055
@dfandrich dfandrich force-pushed the dfandrich/categories branch from 75d3181 to c272de9 Compare June 28, 2024 22:32
@github-actions github-actions bot added the tests label Jun 28, 2024
bagder
bagder approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@bagder bagder added the feature-window A merge of this requires an open feature window label Jul 1, 2024
@dfandrich
Copy link
Contributor Author

Since #14101 was just submitted, it makes sense for this to go in now as well to help people with the new categories.

@dfandrich dfandrich force-pushed the dfandrich/categories branch from c272de9 to 67de466 Compare July 5, 2024 17:42
@github-actions github-actions bot added the CI Continuous Integration label Jul 5, 2024
@dfandrich
curl: list categories in --help
e90e59a 
This eliminates the need to run an extra help subcommand to get the
possible categories, reducing the friction in getting relevant help.
Tweak the help wording for grammatical accuracy. Use ARRAYSIZE() for
cleaner code.

Closes #14055
@dfandrich dfandrich force-pushed the dfandrich/categories branch from 67de466 to e90e59a Compare July 5, 2024 18:05
@bagder
Copy link
Member

bagder commented Jul 5, 2024

Since #14101 was just submitted, it makes sense for this to go in now as well to help people with the new categories.

👍

@bagder bagder removed the feature-window A merge of this requires an open feature window label Jul 5, 2024
@bagder bagder closed this in 6483813 Jul 5, 2024
@bagder bagder deleted the dfandrich/categories branch July 5, 2024 21:10
@dfandrich
Copy link
Contributor Author

dfandrich commented Jul 5, 2024 •
edited
Loading

Looks like you pushed an older version that didn't have the changes to the categories array necessitated by commit 2abfc75. I'll create a follow-up with those changes. UPDATE: pushed commit 127aa61.

dfandrich added a commit that referenced this pull request Jul 5, 2024
@dfandrich
curl: follow-up to fix categories in --help
127aa61 
The commit 6483813 was missing changes necessitated by 2abfc75 that
causes a crash. Also, use ARRAYSIZE() for cleaner code.

Follow-up to 6483813

Ref #14055
@bagder
Copy link
Member

bagder commented Jul 5, 2024

Thanks, sorry for messing that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration cmdline tool tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfandrich @bagder