Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uppoll: prefer <poll.h> over <sys/poll.h> #1406
+6
−6
Conversation
This comment has been minimized.
This comment has been minimized.
mention-bot
commented
Apr 10, 2017
|
@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @yangtse and @dfandrich to be potential reviewers. |
bagder
approved these changes
Apr 10, 2017
MarcelRaad
force-pushed the
MarcelRaad:prefer_poll_h
branch
from
1b6c339
to
aa573c3
Apr 11, 2017
MarcelRaad
merged commit aa573c3
into
curl:master
Apr 11, 2017
MarcelRaad
deleted the
MarcelRaad:prefer_poll_h
branch
Apr 11, 2017
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Apr 12, 2017
lock
bot
locked as resolved and limited conversation to collaborators
May 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
MarcelRaad commentedApr 10, 2017
The POSIX standard location is <poll.h>. Using <sys/poll.h> results in
warning spam when using the musl standard library.