Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poll: prefer <poll.h> over <sys/poll.h> #1406

Merged
merged 1 commit into from Apr 11, 2017
Merged

Conversation

@MarcelRaad
Copy link
Member

MarcelRaad commented Apr 10, 2017

The POSIX standard location is <poll.h>. Using <sys/poll.h> results in
warning spam when using the musl standard library.

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Apr 10, 2017

@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @yangtse and @dfandrich to be potential reviewers.

@bagder
bagder approved these changes Apr 10, 2017
The POSIX standard location is <poll.h>. Using <sys/poll.h> results in
warning spam when using the musl standard library.

Closes #1406
@MarcelRaad MarcelRaad force-pushed the MarcelRaad:prefer_poll_h branch from 1b6c339 to aa573c3 Apr 11, 2017
@MarcelRaad MarcelRaad merged commit aa573c3 into curl:master Apr 11, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MarcelRaad MarcelRaad deleted the MarcelRaad:prefer_poll_h branch Apr 11, 2017
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 12, 2017
Follow-up to aa573c3

Ref: curl#1406
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.