Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help: Add flags to output, ssh category #14076

Closed
wants to merge 2 commits into from

Conversation

yedayak
Copy link
Contributor

@yedayak yedayak commented Jul 1, 2024

Add --output, --remove-on-error, --output-dir and --created-dirs to the output help category
Add --hostpubmd5, --hostpubsha256, --insecure (-k) and --pubkey to the ssh help category

@vszakats
Copy link
Member

vszakats commented Jul 1, 2024

Perhaps the new categories should also be added to the corresponding .md manuals' Category: line in docs/cmdline-opts/?

@yedayak
Copy link
Contributor Author

yedayak commented Jul 1, 2024

Perhaps the new categories should also be added to the corresponding .md manuals' Category: line in docs/cmdline-opts/?

Sure, did that and force pushed

@bagder
Copy link
Member

bagder commented Jul 1, 2024

Maybe --output-dir should go into output as well?

How about --create-dirs ?

Add --output, --remove-on-error, --output-dir and --created-dirs to the output
help category
@yedayak
Copy link
Contributor Author

yedayak commented Jul 2, 2024

Maybe --output-dir should go into output as well?

How about --create-dirs ?

Agreed, added those two

Add --hostpubmd5, --hostpubsha256, --insecure (-k), and --pubkey to the
ssh help category
@yedayak yedayak changed the title help: Add flags to output category help: Add flags to output, ssh category Jul 2, 2024
@yedayak
Copy link
Contributor Author

yedayak commented Jul 2, 2024

I added two more commits that add options to the ssh category, and mention the exact command needed to generate the tool_listhelp.c

scripts/managen Outdated
@@ -918,7 +918,7 @@ sub listhelp {
* This source file is generated with the following command in an autotools
* build:
*
* "make listhelp"
* "make -C docs/cmdline-opts/ listhelp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* "make -C docs/cmdline-opts/ listhelp"
* "make -C docs/cmdline-opts listhelp"

For consistency with other similar lines, e.g. in src/tool_help.h.

@@ -29,7 +29,7 @@
* This source file is generated with the following command in an autotools
* build:
*
* "make listhelp"
* "make -C docs/cmdline-opts/ listhelp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here.

Copy link
Member

@bagder bagder Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can generate the source fine with make listhelp exactly as already documented.

I invoke that command in the src/ directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can generate the source fine with make listhelp exactly as already documented.

I invoke that command in the src/ directory.

OK, that makes sense, I didn't know src/ had it's own targets. Will remove this commit.

@bagder bagder closed this in 62bfcb0 Jul 4, 2024
@bagder
Copy link
Member

bagder commented Jul 4, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants