winbuild: MS-DOS batch tidy-ups #14084
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prefer .bat extension over .cmd for MS-DOS batch, which also avoids confusion with OS/400 .cmd files. - cleanup `echo` quotes, drop them consistently. - delete empty output line from one of the error branches. - prefer lowercase commands like the rest of MS-DOS batches. - delete a contraction. - drop backticks from error message. - use `nmake.exe` consistently. - use equal/not-equal operator style consistently. - inline a single-line `if` branch. - delete exceptions and rules dealing with Windows .cmd extension. Closes #xxxxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.batextension over.cmdfor MS-DOS batch, which also avoidsconfusion with OS/400
.cmdfiles.echoquotes, drop them consistently.nmake.execonsistently.ifbranch..cmdextension.Closes #14084