Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winbuild: MS-DOS batch tidy-ups #14084

Closed
wants to merge 1 commit into from
Closed

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jul 2, 2024

  • prefer .bat extension over .cmd for MS-DOS batch, which also avoids
    confusion with OS/400 .cmd files.
  • cleanup echo quotes, drop them consistently.
  • delete empty output line from one of the error branches.
  • prefer lowercase commands like the rest of MS-DOS batches.
  • delete a contraction.
  • drop backticks from error message.
  • use nmake.exe consistently.
  • use equal/not-equal operator style consistently.
  • inline a single-line if branch.
  • delete exceptions and rules dealing with Windows .cmd extension.

Closes #14084

- prefer .bat extension over .cmd for MS-DOS batch, which also avoids
  confusion with OS/400 .cmd files.
- cleanup `echo` quotes, drop them consistently.
- delete empty output line from one of the error branches.
- prefer lowercase commands like the rest of MS-DOS batches.
- delete a contraction.
- drop backticks from error message.
- use `nmake.exe` consistently.
- use equal/not-equal operator style consistently.
- inline a single-line `if` branch.
- delete exceptions and rules dealing with Windows .cmd extension.

Closes #xxxxx
@vszakats vszakats added Windows Windows-specific tidy-up labels Jul 2, 2024
@github-actions github-actions bot added the CI Continuous Integration label Jul 2, 2024
@vszakats vszakats closed this in 092c07d Jul 2, 2024
@vszakats vszakats deleted the batch-tidy-1 branch July 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tidy-up Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

None yet

1 participant