Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: improve vcpkg cache, add BoringSSL ECH and LibreSSL MSVC jobs #14090

Closed
wants to merge 13 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jul 3, 2024

Closes #14090


TODO:

@vszakats vszakats marked this pull request as draft July 3, 2024 08:26
@github-actions github-actions bot added Windows Windows-specific CI Continuous Integration labels Jul 3, 2024
@vszakats vszakats force-pushed the vcpkg-tweaks branch 2 times, most recently from c39e82c to bb14051 Compare July 3, 2024 22:36
@vszakats
Copy link
Member Author

vszakats commented Jul 4, 2024

Hit this with LibreSSL from vcpkg. There is some confusion with also picking up a non-vcpkg OpenSSL, may be related:

libcurl-d.lib(unity_0_c.obj) : error LNK2019: unresolved external symbol sk_num referenced in function Curl_ossl_verifyhost [D:\a\curl\curl\bld\src\curl.vcxproj]
libcurl-d.lib(unity_0_c.obj) : error LNK2019: unresolved external symbol sk_value referenced in function Curl_ossl_verifyhost [D:\a\curl\curl\bld\src\curl.vcxproj]
libcurl-d.lib(unity_0_c.obj) : error LNK2019: unresolved external symbol sk_pop_free referenced in function cert_stuff [D:\a\curl\curl\bld\src\curl.vcxproj]
libcurl-d.lib(unity_0_c.obj) : error LNK2019: unresolved external symbol sk_pop referenced in function cert_stuff [D:\a\curl\curl\bld\src\curl.vcxproj]
libcurl-d.lib(unity_0_c.obj) : error LNK2019: unresolved external symbol EVP_MD_CTX_create referenced in function Curl_sha512_256it [D:\a\curl\curl\bld\src\curl.vcxproj]
libcurl-d.lib(unity_0_c.obj) : error LNK2019: unresolved external symbol EVP_MD_CTX_destroy referenced in function Curl_sha512_256it [D:\a\curl\curl\bld\src\curl.vcxproj]
libcurl-d.lib(unity_0_c.obj) : error LNK2019: unresolved external symbol SSL_CTX_add0_chain_cert referenced in function SSL_CTX_use_certificate_chain_blob [D:\a\curl\curl\bld\src\curl.vcxproj]
libcurl-d.lib(unity_0_c.obj) : error LNK2019: unresolved external symbol SSL_CTX_clear_chain_certs referenced in function SSL_CTX_use_certificate_chain_blob [D:\a\curl\curl\bld\src\curl.vcxproj]
libcurl-d.lib(unity_0_c.obj) : error LNK2019: unresolved external symbol SSL_CTX_set1_groups_list referenced in function Curl_ossl_ctx_init [D:\a\curl\curl\bld\src\curl.vcxproj]
libcurl-d.lib(unity_0_c.obj) : error LNK2019: unresolved external symbol SSL_CTX_set_min_proto_version referenced in function ossl_set_ssl_version_min_max [D:\a\curl\curl\bld\src\curl.vcxproj]
libcurl-d.lib(unity_0_c.obj) : error LNK2019: unresolved external symbol SSL_CTX_set_max_proto_version referenced in function ossl_set_ssl_version_min_max [D:\a\curl\curl\bld\src\curl.vcxproj]
D:\a\curl\curl\bld\src\curl.exe : fatal error LNK1120: 11 unresolved externals [D:\a\curl\curl\bld\src\curl.vcxproj]

Ref: https://github.com/curl/curl/actions/runs/9787764034/job/27024766559#step:6:41

@talregev
Copy link
Contributor

talregev commented Jul 4, 2024

You can have hints in the vcpkg patches.

@vszakats
Copy link
Member Author

vszakats commented Jul 4, 2024

You can have hints in the vcpkg patches.

Do you have a specific place to look? (I checked the LibreSSL package, which says it's incompatible with OpenSSL, but the build phase is fine, the issue comes when trying to build against curl. Perhaps a vcpkg curl patch/wrapper?)

@talregev
Copy link
Contributor

talregev commented Jul 4, 2024

vcpkg curl patches / wrapper
one hint:
Curl should add the dependencies of the packages.

@vszakats vszakats changed the title GHA: try vcpkg tweaks GHA: improve vcpkg caching and use Jul 7, 2024
@vszakats vszakats marked this pull request as ready for review July 7, 2024 12:43
@vszakats vszakats changed the title GHA: improve vcpkg caching and use GHA: improve vcpkg cache/use, add BoringSSL ECH and LibreSSL jobs Jul 7, 2024
@vszakats vszakats changed the title GHA: improve vcpkg cache/use, add BoringSSL ECH and LibreSSL jobs GHA: improve vcpkg cache/use, add BoringSSL ECH and LibreSSL MSVC jobs Jul 7, 2024
@vszakats vszakats changed the title GHA: improve vcpkg cache/use, add BoringSSL ECH and LibreSSL MSVC jobs GHA: improve vcpkg use, add BoringSSL ECH and LibreSSL MSVC jobs Jul 7, 2024
@vszakats vszakats changed the title GHA: improve vcpkg use, add BoringSSL ECH and LibreSSL MSVC jobs GHA: improve vcpkg cache, add BoringSSL ECH and LibreSSL MSVC jobs Jul 7, 2024
@vszakats vszakats added the TLS label Jul 7, 2024
@vszakats vszakats closed this in f99c08d Jul 7, 2024
@vszakats vszakats deleted the vcpkg-tweaks branch July 7, 2024 15:22
vszakats added a commit to vszakats/curl that referenced this pull request Jul 12, 2024
Follow-up to f99c08d curl#14090
Follow-up to e26cbe2 curl#13979

Closes #xxxxx
vszakats added a commit that referenced this pull request Jul 12, 2024
Now that the package reached the CI runner image.

Follow-up to f99c08d #14090
Follow-up to e26cbe2 #13979

Closes #14170
meslubi2021 pushed a commit to meslubi2021/curl that referenced this pull request Jul 19, 2024
Now that the package reached the CI runner image.

Follow-up to f99c08d curl#14090
Follow-up to e26cbe2 curl#13979

Closes curl#14170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration TLS Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

None yet

2 participants