-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
GHA: improve vcpkg cache, add BoringSSL ECH and LibreSSL MSVC jobs #14090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c39e82c
to
bb14051
Compare
Hit this with LibreSSL from vcpkg. There is some confusion with also picking up a non-vcpkg OpenSSL, may be related:
Ref: https://github.com/curl/curl/actions/runs/9787764034/job/27024766559#step:6:41 |
You can have hints in the vcpkg patches. |
Do you have a specific place to look? (I checked the LibreSSL package, which says it's incompatible with OpenSSL, but the build phase is fine, the issue comes when trying to build against curl. Perhaps a vcpkg curl patch/wrapper?) |
vcpkg curl patches / wrapper |
These builds are using MSBuild, not Ninja, and the curl build doesn't seem to generate most files, except the configuration log, which we dump already. For anything else comes up, we can dump them too in a dedicated step.
Follow-up to f99c08d curl#14090 Follow-up to e26cbe2 curl#13979 Closes #xxxxx
Now that the package reached the CI runner image. Follow-up to f99c08d curl#14090 Follow-up to e26cbe2 curl#13979 Closes curl#14170
cache on a per-package basis.
Replace manual caching with a built-in solution. It shares cached
package builds between jobs, e.g. libssh2 only builds once
per platform (instead of once per job). Individual packages are built
as needed (not the whole per-job tree). It also fixes the duplicate
cache entry issues.
Ref: https://learn.microsoft.com/en-us/vcpkg/consume/binary-caching-github-actions-cache
Follow-up to e26cbe2 GHA: use vcpkg to install packages for MSVC jobs #13979
Follow-up to cb22cfc GHA: add MSVC UWP job, expand jobs with more options #14077
add BoringSSL job with ECH enabled. The first such job in the curl CI.
add LibreSSL job.
use vcpkg pre-installed on the runner image, instead of rolling our
own. This is quicker, simpler and more robust.
Follow-up to e26cbe2 GHA: use vcpkg to install packages for MSVC jobs #13979
show pre-installed vcpkg and ports version.
drop
gsasl
dependency till it reaches the pre-installed vcpkg ports.re-add
find .
to see the binaries generated.simplify setting up
PATH
.exclude failing tests for any job enabling WinIDN.
drop collecting and uploading log archives. We already dump CMake
logs, and our build doesn't use Ninja. Rest of files weren't generated
by the curl build. We don't aim to debug vcpkg package builds.
Closes #14090
TODO: