Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool_operate: simplify return code handling from url_proto() #14104

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jul 4, 2024

The additional checks were superfluous as it would only ever return error if one of those protocols were set. Also: a returned error should mean get out of there, without having to check more conditions.

The additional checks were superfluous as it would only ever return
error if one of those protocols were set. Also: a returned error
*should* mean get out of there, without having to check more conditions.
@bagder bagder closed this in 655557f Jul 5, 2024
@bagder bagder deleted the bagder/operate-url_proto branch July 5, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant