-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Update GIT-INFO.md for perl version requirements. #14112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Per ChatGPT, the `<:crlf` discipline was added to `open()` in Perl 5.8.0. I tried running `scripts/managen` on a machine that has Perl 5.6.1 and got an error: ``` Unknown open() mode ':<crlf' at ../../scripts/managen line 777. ```
Convert list of requirements to a valid list in Markdown.
FWIW, another GPT gives this answer to the same question: To "are you sure?", it replies with a different version: Is this somewhere documented in a canonical source? |
The canonical location for version information is docs/INTERNALS.md. I didn't
realize there were some versions duplicated in GIT-INFO.md and I don't think we
should bother keeping both. GIT-INFO.md should probably defer to
docs/INTERNALS.md for versions if it's going to mention specific requirements
at all.
INTERNALS.md says perl 5.6 is (was?) fine (released in 2000) so moving to 5.8
(released 2002) should be fine. Our "Old Linux" CI build uses 5.24 so there's
no problem there.
|
Excellent feedback is excellent. Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
I did some digging, but didn't study the Looking at the release timeline, that is after Perl 5.6.0 but before 5.8.0: https://en.wikipedia.org/wiki/Perl_5_version_history I think this predates
And I believe this feature is part of |
Thanks! I made that update, but I'm wondering if |
GIT-INFO.md is not shipped in the tar balls, so it should be restricted to
containing information of use to users who clone the git repo. That means
autoconf info should be there since they won't get the pre-generated autoconf
files, but I think that file should just point to INTERNALS.md for people who
want the versions information. perl is needed by everyone, not just users clone
from git, so I don't think it really bears mentioning there.
I know this isn't really about this PR, but if GIT-INFO is being updated I
think it should be updated One Final Time so we don't need to keep two docs in
sync. Let's see if anyone else agrees.
|
GIT-INFO.md
Outdated
See [docs/INTERNALS.md][0] for information on the requirements that you'll | ||
need or `autoreconf` and `configure` (not `buildconf.bat`) to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See [docs/INTERNALS.md][0] for information on the requirements that you'll | |
need or `autoreconf` and `configure` (not `buildconf.bat`) to work. | |
See [docs/INTERNALS.md][0] for requirement details. |
... and I think the next paragraph can be completely removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! How does this look now?
Thanks! |
Per ChatGPT, the
<:crlf
discipline was added toopen()
in Perl 5.8.0. I tried runningscripts/managen
on a machine that has Perl 5.6.1 and got an error:While I was in there, I also made the list of requirements a valid Markdown list, so it displays properly when viewed in GitHub.
Before:
After:
I made these separate commits, so you can not take either change if you wish.
Thanks!