-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getinfo: CURLINFO_POSTTRANSFER_TIME_T #14189
Conversation
See discussion here, note that I'm missing documentation which I'll add once this PR is accepted. |
7364bb4
to
1803363
Compare
1803363
to
b7d647b
Compare
@bagder are you ok with this change? If so I'll update the docs to reflect this PR. |
b7d647b
to
79b8309
Compare
This PR still breaks a lot of tests. |
78fb4b1
to
73eb2ce
Compare
@bagder - Most tests are now passing. I still see a failure in 1541 on 'Linux / AM hyper' where Is it possible for |
@bagder -merge window is about to close, could I please get a response on the above? |
I just tested your PR locally with a hyper build and yes, that's exactly what (not) happens. |
Made #14539 to add the missing call in hyper. |
@alexsn please rebase on top of master and force-push. Should work now! |
73eb2ce
to
0ff679a
Compare
I would exclude test500 from hyper. The time of the sending is a guess in hyper. |
You want me to do it in this PR? |
That would be best. |
Returns the time, in microseconds, from the start until the last byte is sent by libcurl (i.e. the request is sent off).
0ff679a
to
9c8830d
Compare
Thanks! |
Returns the time, in microseconds, from the start until the last byte is sent by libcurl (i.e. the request is sent off).
Note that I've used
timerid->TIMER_POSTRANSFER
as it was defined but unused.