Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getinfo: CURLINFO_POSTTRANSFER_TIME_T #14189

Closed
wants to merge 1 commit into from

Conversation

alexsn
Copy link

@alexsn alexsn commented Jul 15, 2024

Returns the time, in microseconds, from the start until the last byte is sent by libcurl (i.e. the request is sent off).

Note that I've used timerid->TIMER_POSTRANSFER as it was defined but unused.

@alexsn
Copy link
Author

alexsn commented Jul 15, 2024

See discussion here, note that I'm missing documentation which I'll add once this PR is accepted.

@alexsn alexsn force-pushed the curlinfo_posttransfer_time branch from 7364bb4 to 1803363 Compare July 15, 2024 09:12
@alexsn alexsn force-pushed the curlinfo_posttransfer_time branch from 1803363 to b7d647b Compare July 15, 2024 09:34
@bagder bagder added the feature-window A merge of this requires an open feature window label Jul 15, 2024
@alexsn
Copy link
Author

alexsn commented Jul 16, 2024

@bagder are you ok with this change? If so I'll update the docs to reflect this PR.

@alexsn alexsn force-pushed the curlinfo_posttransfer_time branch from b7d647b to 79b8309 Compare July 25, 2024 11:39
@bagder
Copy link
Member

bagder commented Aug 3, 2024

This PR still breaks a lot of tests.

@alexsn alexsn force-pushed the curlinfo_posttransfer_time branch 8 times, most recently from 78fb4b1 to 73eb2ce Compare August 6, 2024 09:58
@alexsn
Copy link
Author

alexsn commented Aug 6, 2024

@bagder - Most tests are now passing. I still see a failure in 1541 on 'Linux / AM hyper' where CURLINFO_POSTTRANSFER_TIME_T is zero after curl_easy_perform is done (though this test runs on all platforms without errors).

Is it possible for req_set_upload_done to not get called?

@alexsn
Copy link
Author

alexsn commented Aug 13, 2024

@bagder -merge window is about to close, could I please get a response on the above?

@bagder
Copy link
Member

bagder commented Aug 14, 2024

Is it possible for req_set_upload_done to not get called?

I just tested your PR locally with a hyper build and yes, that's exactly what (not) happens. req_set_upload_done is not called... /cc @icing

@icing
Copy link
Contributor

icing commented Aug 14, 2024

req_set_upload_done

Made #14539 to add the missing call in hyper.

@bagder
Copy link
Member

bagder commented Aug 14, 2024

@alexsn please rebase on top of master and force-push. Should work now!

@icing
Copy link
Contributor

icing commented Aug 14, 2024

I would exclude test500 from hyper. The time of the sending is a guess in hyper.

@alexsn
Copy link
Author

alexsn commented Aug 14, 2024

I would exclude test500 from hyper. The time of the sending is a guess in hyper.

You want me to do it in this PR?

@icing
Copy link
Contributor

icing commented Aug 14, 2024

I would exclude test500 from hyper. The time of the sending is a guess in hyper.

You want me to do it in this PR?

That would be best.

    Returns the time, in microseconds, from the start until the last
    byte is sent by libcurl (i.e. the request is sent off).
@github-actions github-actions bot added the CI Continuous Integration label Aug 15, 2024
@bagder bagder closed this in 1365041 Aug 15, 2024
@bagder
Copy link
Member

bagder commented Aug 15, 2024

Thanks!

@alexsn alexsn deleted the curlinfo_posttransfer_time branch August 15, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration cmdline tool feature-window A merge of this requires an open feature window libcurl API tests
Development

Successfully merging this pull request may close these issues.

3 participants