GHA/windows: add MSVC wolfSSL job with test #14193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
requested changes
Jul 15, 2024
vszakats
approved these changes
Jul 15, 2024
vszakats
changed the title
vszakats
changed the title
|
Thanks @talregev, merged! |
meslubi2021
pushed a commit
to Unity-Curl/curl
that referenced
this pull request
Jul 19, 2024
Fix the file of wolfssl.c because of this warning/error: ``` curl\lib\vtls\wolfssl.c(1017,42): error C2220: the following warning is treated as an error [curl\bld\lib\libcurl_object.vcxproj] curl\lib\vtls\wolfssl.c(1017,42): warning C4267: 'function': conversion from 'size_t' to 'unsigned long', possible loss of data [curl\bld\lib\libcurl_object.vcxproj] ``` `size_t` in MSVC is different. Change it to `unsigned long` because `wolfSSL_ERR_error_string_n` last argument is defined as `unsigned long`. Closes curl#14193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the file of wolfssl.c because of this warning/error:
size_tin MSVC is different. Change it tounsigned longbecausewolfSSL_ERR_error_string_nlast argument is defined asunsigned long.Closes #14193