ssl: Fix compilation with OpenSSL 1.x with md4 disabled #14218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the failing test known to be flaky? What exactly failed there? |
|
Yes, all Windows native tests are flaky. |
So should I rerun it? How? |
bagder
approved these changes
Jul 18, 2024
You can click on the job that failed, and then on "re-run failed jobs" in the menu at the top. I just did that, and enabled debug logging as there was no output at all for the tests, only the failure mark. |
MarcelRaad
approved these changes
Jul 18, 2024
bagder
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Ah yes, using an #else there as mentioned by @MarcelRaad makes sense.
If OpenSSL 1.x is used, and it is configured with md4 disabled, OPENSSL_NO_MD4 is defined in opensslconf.h, but this header was not included before checking for this define. Later in md4.c, openssl/md4.h is included, and it includes that header indirectly, leading to inconsistency within md4.c. Since the md4.h branch was taken, wincrypt.h (or others) is not included, and later below the USE_WIN32_CRYPTO branch is taken, but the types are not defined.
|
Done |
bagder
approved these changes
Jul 19, 2024
|
Thanks! |
meslubi2021
pushed a commit
to Unity-Curl/curl
that referenced
this pull request
Jul 19, 2024
If OpenSSL 1.x is used, and it is configured with md4 disabled, OPENSSL_NO_MD4 is defined in opensslconf.h, but this header was not included before checking for this define. Later in md4.c, openssl/md4.h is included, and it includes that header indirectly, leading to inconsistency within md4.c. Since the md4.h branch was taken, wincrypt.h (or others) is not included, and later below the USE_WIN32_CRYPTO branch is taken, but the types are not defined. Closes curl#14218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If OpenSSL 1.x is used, and it is configured with md4 disabled, OPENSSL_NO_MD4 is defined in opensslconf.h, but this header was not included before checking for this define.
Later in md4.c, openssl/md4.h is included, and it includes that header indirectly, leading to inconsistency within md4.c.
Since the md4.h branch was taken, wincrypt.h (or others) is not included, and later below the USE_WIN32_CRYPTO branch is taken, but the types are not defined.