openssl: don't try to print nonexistant peer private keys #1425

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@davidben
Contributor

X.509 certificates carry public keys, not private keys. Fields
corresponding to the private half of the key will always be NULL.

@davidben davidben openssl: don't try to print nonexistant peer private keys
X.509 certificates carry public keys, not private keys. Fields
corresponding to the private half of the key will always be NULL.
1c2c6f2

@davidben, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @yangtse and @captain-caveman2k to be potential reviewers.

@bagder
bagder approved these changes Apr 17, 2017 View changes

Hah, what a fine catch - even if I feel a bit silly for having added that code once!

@bagder bagder added the SSL/TLS label Apr 17, 2017
@bagder bagder added a commit that closed this pull request Apr 17, 2017
@davidben @bagder davidben + bagder openssl: don't try to print nonexistant peer private keys
X.509 certificates carry public keys, not private keys. Fields
corresponding to the private half of the key will always be NULL.

Closes #1425
997504e
@bagder bagder closed this in 997504e Apr 17, 2017
Owner
bagder commented Apr 17, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment