New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: don't try to print nonexistant peer private keys #1425

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@davidben
Contributor

davidben commented Apr 17, 2017

X.509 certificates carry public keys, not private keys. Fields
corresponding to the private half of the key will always be NULL.

openssl: don't try to print nonexistant peer private keys
X.509 certificates carry public keys, not private keys. Fields
corresponding to the private half of the key will always be NULL.
@mention-bot

This comment has been minimized.

mention-bot commented Apr 17, 2017

@davidben, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @yangtse and @captain-caveman2k to be potential reviewers.

@bagder

bagder approved these changes Apr 17, 2017

Hah, what a fine catch - even if I feel a bit silly for having added that code once!

@bagder bagder added the SSL/TLS label Apr 17, 2017

@bagder bagder closed this in 997504e Apr 17, 2017

@bagder

This comment has been minimized.

Member

bagder commented Apr 17, 2017

thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.