Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
SChannel/WinSSL: Implement public key pinning #1429
This implements public key pinning for the schannel backend. Currently it works with pem/der/hashes, but only if the remote server has a RSA key with a length of 2048 or 4096 bits. I'm looking for help with this error that occurs with ecDSA keys (regardless of PROV_RSA_FULL or PROV_RSA_AES):
And also hoping that I don't really have to resort to the horrible hard-coded header hacks that the apple backend had to do:
Is there a proper way to change a PUBLICKEYBLOB to a DER (or a PEM that I can convert)?
Also thoughts about this working on XP, 8, or 10 would be appreciated too, I've only tested on 7 SP1.
Hey @bagder, I will try to take a look this weekend. I don't have much time at the moment and I am drowning in roughly 3000 GitHub notifications and 1000 mailinglist mails. If something like this comes up, could you please send me a direct message? Thanks. :-)
Thanks for your hard work on this feature and pull-request, I really appreciate it. I hope that you will find the time to address my review comments, thanks!
@dscho Thanks for the offer and that amazing runtime TLS switching work. I can probably handle the merge conflicts myself whenever I get around to spinning windows back up and cleaning this up to be merged.
I'm still unable to support anything but RSA keys with bit length of 2048 or 4096, but unless someone who knows what they are doing with schannel comes along, I'll probably just submit it as-is. It's better than nothing anyway. :)
referenced this pull request
Sep 1, 2017
As you say, it is better than nothing! And if anybody comes along with the need for different sizes, then that will give them a perfect opportunity to "pay back" to the project ;-)
In October @boris9000 (thanks!) put in a pull request to fix this patch to support all types of certificates and keys. I finally got another windows dev box spun up and was able to rebase my and his commit on top of master, including the new runtime TLS backend support.
I have tested it with rsa4096 and ecDSA Secp256r1 keys like so:
Additionally I added another not-really-needed commit to replace Curl_none_md5sum with Curl_schannel_md5sum, if this isn't desired I can pull it.
If @dscho wouldn't mind giving it a quick once-over to make sure I didn't do anything to harm the runtime TLS stuff, and @mback2k wouldn't mind making sure the windows specific code looks OK then I believe it is ready to merge.
Note: I have only tested this on Windows 7 SP1 x86, and don't really have the ability to run it on anything else.