-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all tests pass with rustls backend #14317
Conversation
Remove workaround, and re-enable tests.
This enables support for `CURLOPT_CRLFILE` in the rustls TLS backend.
`rustls_web_pki_server_cert_verifier_builder_new` does not take ownership of its argument.
`rustls_client_config_builder_set_server_verifier` has refcount semantics on its argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The diff looks good to me, but my experience in this repo is about the same as yours :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Our rustls CI job uses |
That's the rustls-ffi version (the C bindings for rustls) and is current. |
That is the current version, which underneath uses rustls 0.23.4 (released ~March 2024). So it's pretty current. ^snap |
Sorry, thought I was safe replying based on time zones but we raced! 😃 |
Ah, that makes sense. Thanks! |
Thanks! |
The goal of this PR is to remove the rustls stanza in
tests/data/DISABLED
that skips some tests.That involves supporting CRLs -- we've had upstream support for a little while, but needs some plumbing in here.
This is my first curl PR, so please shout if I've made any beginner errors: but I have run the tests and run
make checksrc
.