-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: distcheck for files in CMake subdir #14323
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fail check successful:
https://github.com/curl/curl/actions/runs/10179228619/job/28154528586?pr=14323#step:3:346 |
9c110ba
to
732ea32
Compare
bagder
reviewed
Jul 31, 2024
732ea32
to
43dd5bb
Compare
Cut it back a little. It adds an extra |
Now without the extra file, with a small, hopefully non-offensive hack. |
e59015c
to
6888340
Compare
6888340
to
76d60f4
Compare
- add CMake option to verify if the `CMake/*.cmake`, `CMake/*.in` files are listed as distributable in autotools' `EXTRA_DIST`. The check can be enabled with `-DENABLE_DIST_TEST=ON` CMake option. - add CI job to that effect. Ref: curl#14320 Closes curl#14323
76d60f4
to
c293427
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Aug 9, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add CMake option to verify if the
CMake/*.cmake
,CMake/*.in
filesare listed as distributable in autotools'
EXTRA_DIST
. The check canbe enabled with
-DENABLE_DIST_TEST=ON
CMake option.add CI job to that effect.
Ref: #14320
Closes #14323
FindNettle.cmake
#14320IN_LIST
is CMake 3.3: https://cmake.org/cmake/help/latest/command/if.html#in-list