CHANGES: rename to CHANGES.md, no longer generated #14331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since CHANGES is such a standard location to look for, should we include one that say "look at RELEASE-NOTES"? |
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Aug 1, 2024
curl tarballs since 8.8.0 are reproducible, and any file is fine as a timestamp reference. `CHANGES` may be dropped from future tarballs, so switch to one that's there to stay. curl/curl#14331
A reasonable note to add, yes. |
- scripts/log2changes.pl was not included in release tarballs, which broke reproducible builds - since log2changes uses git to generate the contents, it makes it difficult to generate the same contents later (it would need to be fixed) - the CHANGES file has outlived its purpose. the main changes are in the RELEASE-NOTES, the rest are better tracked directly using git or on GitHub - put a fixed CHANGES.md in there instead pointing out where the info lives now Closes #14331
bagder
force-pushed
the
bagder/rm-changes
branch
from
d5d09f4
to
688901e
Compare
|
@vszakats The curl-for-win jobs fail here because it seems they access |
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Aug 1, 2024
Ref: curl/curl#14331 Follow-up to d79d7a6
|
I did few minutes after you opening the PR, but forgot it's also in the distro pack, thanks for the ping! Should be fine now after curl/curl-for-win@fa22468. |
bagder
changed the title
bagder
added a commit
to curl/curl-for-win
that referenced
this pull request
Aug 1, 2024
Syncing up with curl/curl#14331 which renames the `CHANGES` file to `CHANGES.md` and no longer generates it in releases.
|
Thanks! |
vszakats
reviewed
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scripts/log2changes.pl was not included in release tarballs, which broke reproducible builds
since log2changes uses git to generate the contents, it makes it difficult to generate the same contents later (it would need to be fixed)
the CHANGES file has outlived its purpose. the main changes are in the RELEASE-NOTES, the rest are better tracked directly using git or on GitHub