GHA: scan git repository and detect unvetted binary files #14333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only binary-looking files that are accepted in the git repository need to match the checksums in the sha256sum file ".github/scripts/binarycheck.sums". This is done to make sure that no one has planted any hidden (encrypted) potentially dangerous payload in the tree. Closes #14333
bagder
force-pushed
the
bagder/GHA-binary-detector
branch
from
b7fe158 to
83783fd
Compare
|
A laudable goal, but there are a lot of places where base64 encoded binaries
can and do live right now. Someone who wants an arbitrary binary can easily
bypass this check that way.
|
|
Sure, but it's about raising reasonable "guard rails" here - not fooling anyone into saying that we can automatically detect any malicious payload. We don't accept large base encoded chunks either, but we reject those by manual review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only binary-looking files that are accepted in the git repository need to match the sha256sum file .github/scripts/binarycheck.sums.
This is done to make sure that no one has planted any hidden (encrypted) potentially dangerous payload in the tree.