Skip to content

vtls: fix MSVC cast truncates constant value warning - #14341

Closed
talregev wants to merge 1 commit into
curl:masterfrom
talregev:TalR/trunced_warning_mbedtls
Closed

talregev wants to merge 1 commit into
curl:masterfrom
talregev:TalR/trunced_warning_mbedtls

Conversation

@talregev

@talregev talregev commented Aug 1, 2024 •

Copy link
Copy Markdown
Contributor

Fixes:

curl\lib\vtls\cipher_suite.c(193,3): error C2220: the following warning is treated as an error
curl\lib\vtls\cipher_suite.c(193,3): warning C4310: cast truncates constant value

Closes #14341

@talregev talregev changed the title GHA/windows: Handle MSVC cast truncates constant value warning MbedTLS: Handle MSVC cast truncates constant value warning Aug 1, 2024
@github-actions github-actions Bot added the TLS label Aug 1, 2024
@vszakats vszakats changed the title MbedTLS: Handle MSVC cast truncates constant value warning mbedtls: handle MSVC cast truncates constant value warning Aug 1, 2024
@vszakats

vszakats commented Aug 1, 2024

Copy link
Copy Markdown
Member

Would you mind copying the original warning message to the commit text?

@vszakats vszakats added the build label Aug 1, 2024
D:\a\curl\curl\lib\vtls\cipher_suite.c(193,3): error C2220: the following warning is treated as an error [D:\a\curl\curl\bld\lib\libcurl_object.vcxproj]
D:\a\curl\curl\lib\vtls\cipher_suite.c(193,3): warning C4310: cast truncates constant value [D:\a\curl\curl\bld\lib\libcurl_object.vcxproj]
@talregev
talregev force-pushed the TalR/trunced_warning_mbedtls branch from a470ca9 to 266e4d9 Compare August 1, 2024 21:07
@talregev

talregev commented Aug 1, 2024

Copy link
Copy Markdown
Contributor Author

Would you mind copying the original warning message to the commit text?

Done.

@vszakats vszakats changed the title mbedtls: handle MSVC cast truncates constant value warning vtls: fix MSVC cast truncates constant value warning Aug 3, 2024
@vszakats vszakats closed this in bb9c15e Aug 3, 2024
@vszakats

vszakats commented Aug 3, 2024

Copy link
Copy Markdown
Member

Thank you!

@talregev
talregev deleted the TalR/trunced_warning_mbedtls branch August 3, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants