Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtls: fix MSVC cast truncates constant value warning #14341

Closed
wants to merge 1 commit into from

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Aug 1, 2024

Fixes:

curl\lib\vtls\cipher_suite.c(193,3): error C2220: the following warning is treated as an error
curl\lib\vtls\cipher_suite.c(193,3): warning C4310: cast truncates constant value

Closes #14341

@talregev talregev changed the title GHA/windows: Handle MSVC cast truncates constant value warning MbedTLS: Handle MSVC cast truncates constant value warning Aug 1, 2024
@github-actions github-actions bot added the TLS label Aug 1, 2024
@vszakats vszakats changed the title MbedTLS: Handle MSVC cast truncates constant value warning mbedtls: handle MSVC cast truncates constant value warning Aug 1, 2024
@vszakats
Copy link
Member

vszakats commented Aug 1, 2024

Would you mind copying the original warning message to the commit text?

@vszakats vszakats added the build label Aug 1, 2024
D:\a\curl\curl\lib\vtls\cipher_suite.c(193,3): error C2220: the following warning is treated as an error [D:\a\curl\curl\bld\lib\libcurl_object.vcxproj]
D:\a\curl\curl\lib\vtls\cipher_suite.c(193,3): warning C4310: cast truncates constant value [D:\a\curl\curl\bld\lib\libcurl_object.vcxproj]
@talregev talregev force-pushed the TalR/trunced_warning_mbedtls branch from a470ca9 to 266e4d9 Compare August 1, 2024 21:07
@talregev
Copy link
Contributor Author

talregev commented Aug 1, 2024

Would you mind copying the original warning message to the commit text?

Done.

@vszakats vszakats changed the title mbedtls: handle MSVC cast truncates constant value warning vtls: fix MSVC cast truncates constant value warning Aug 3, 2024
@vszakats vszakats closed this in bb9c15e Aug 3, 2024
@vszakats
Copy link
Member

vszakats commented Aug 3, 2024

Thank you!

@talregev talregev deleted the TalR/trunced_warning_mbedtls branch August 3, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants