Repository navigation
Conversation
bagder
force-pushed
the
bagder/verify-release
branch
from
August 2, 2024 07:40
a70da56 to
9a08e18
Compare
... so that we can avoid the build failure if we run this in a clean checkout. Also remove -it from the docker invoke since it is not interactive and it needs no TTY. They made the job fail in the CI.
Also fix the .dist replacing by avoiding all Makefiles because it otherwise also went into the temporary release folder and got confused about the Makefile.dist in there.
bagder
force-pushed
the
bagder/verify-release
branch
from
August 2, 2024 08:27
327a799 to
f71265d
Compare
Member
|
Do we need the old |
Member
Author
Ah no. This new one is a more complete test that supersedes the old one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify in this case means making sure that rebuilding the tarball generates the exact same output.
The verify-release script requires 754acd1, so it does not work on past curl release tarballs.