cmake: drop no-op tests/data/CMakeLists.txt
#14357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really wished you had not done this. This adds non-trivial work for like 20 pending PRs... |
|
Can't really do any good over here! I'm sorry. |
|
No need to be fatalistic. Just me reminding you and others that central files we update in just about every commit probably need some syncing and discussion before we rename to reduce friction. |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Aug 4, 2024
Follow-up to f5b8265 curl#14357 Reported-by: Stefan Eissing Fixes curl#14371 Closes #xxxxx
vszakats
added a commit
that referenced
this pull request
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a no-op since
d162fca #9333 (2022-08-18).
Also revert 476499c that is
no longer necessary: move
Makefile.incback intoMakefile.am.Closes #14357