Skip to content

cmake: drop no-op tests/data/CMakeLists.txt - #14357

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:cm-dropsubdir
Closed

vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:cm-dropsubdir

Conversation

@vszakats

@vszakats vszakats commented Aug 2, 2024 •

Copy link
Copy Markdown
Member

It's a no-op since
d162fca #9333 (2022-08-18).

Also revert 476499c that is
no longer necessary: move Makefile.inc back into Makefile.am.

Closes #14357

It's a no-op since
d162fca curl#9333 (2022-08-18).

Also revert 476499c that is no
longer necessary.

Closes #xxxxx
@github-actions github-actions Bot added the tests label Aug 2, 2024
@vszakats vszakats closed this in f5b8265 Aug 2, 2024
@vszakats
vszakats deleted the cm-dropsubdir branch August 2, 2024 23:16
@bagder

bagder commented Aug 3, 2024

Copy link
Copy Markdown
Member

I really wished you had not done this. This adds non-trivial work for like 20 pending PRs...

@vszakats

vszakats commented Aug 3, 2024

Copy link
Copy Markdown
Member Author

Can't really do any good over here! I'm sorry.

@bagder

bagder commented Aug 3, 2024

Copy link
Copy Markdown
Member

No need to be fatalistic. Just me reminding you and others that central files we update in just about every commit probably need some syncing and discussion before we rename to reduce friction.

vszakats added a commit to vszakats/curl that referenced this pull request Aug 4, 2024
Follow-up to f5b8265 curl#14357
Reported-by: Stefan Eissing
Fixes curl#14371
Closes #xxxxx
vszakats added a commit that referenced this pull request Aug 4, 2024
Follow-up to f5b8265 #14357
Reported-by: Stefan Eissing
Fixes #14371
Closes #14372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants