Use NGHTTP3 prefix instead of NGTCP2 for errors in h3 callbacks. #14394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To my understanding the functions are nghttp3 callbacks and should therefore return
NGHTTP3_ERR_CALLBACK_FAILURE
.However, this is not critical as the nghttp3 documentation states for all callbacks: (https://nghttp2.org/nghttp3/types.html#c.nghttp3_stop_sending)
For
nghttp3_strerror
, a nghttp3 function sets rc, so I expect a nghttp3 function to transform the error correctly.The values for NGHTTP3_ERR_... and NGTCP2_ERR_... are not the same, so I expect this to be more relevant.