Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NGHTTP3 prefix instead of NGTCP2 for errors in h3 callbacks. #14394

Closed
wants to merge 1 commit into from

Conversation

moritzbuhl
Copy link
Contributor

To my understanding the functions are nghttp3 callbacks and should therefore return NGHTTP3_ERR_CALLBACK_FAILURE.
However, this is not critical as the nghttp3 documentation states for all callbacks: (https://nghttp2.org/nghttp3/types.html#c.nghttp3_stop_sending)

The implementation of this callback must return 0 if it succeeds. Returning NGHTTP3_ERR_CALLBACK_FAILURE will return to the caller immediately. Any values other than 0 is treated as NGHTTP3_ERR_CALLBACK_FAILURE.

For nghttp3_strerror, a nghttp3 function sets rc, so I expect a nghttp3 function to transform the error correctly.
The values for NGHTTP3_ERR_... and NGTCP2_ERR_... are not the same, so I expect this to be more relevant.

@github-actions github-actions bot added the HTTP/3 h3 or quic related label Aug 5, 2024
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@bagder bagder closed this in d266d19 Aug 5, 2024
@bagder
Copy link
Member

bagder commented Aug 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTTP/3 h3 or quic related
Development

Successfully merging this pull request may close these issues.

2 participants