curl_compilers.m4: accept -Og flag #1440
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @bagder and @dfandrich to be potential reviewers. |
jay
reviewed
Apr 22, 2017
m4/curl-compilers.m4
Outdated
| @@ -158,7 +158,7 @@ AC_DEFUN([CURL_CHECK_COMPILER_GNU_C], [ | |||
| flags_dbg_all="$flags_dbg_all -gvms" | |||
| flags_dbg_yes="-g" | |||
| flags_dbg_off="" | |||
| flags_opt_all="-O -O0 -O1 -O2 -O3 -Os" | |||
| flags_opt_all="-O -O0 -O1 -O2 -O3 -Os -Og" | |||
Member
There was a problem hiding this comment.
mention in the commit title this change is gcc specific
curl_compilers.m4: accept -Og gcc flag
Member
Author
There was a problem hiding this comment.
Thanks, how could I overlook -Ofast when studying the GCC optimization flags for almost an hour yesterday...
Changes pushed.
jay
approved these changes
Apr 24, 2017
Member
jay
left a comment
jay
left a comment
There was a problem hiding this comment.
looks good, one nitpick, it's curl-compilers.m4 not curl_compilers.m4
-Og, introduced in GCC 4.8, optimizes for debugging experience. -Ofast, introduced in GCC 4.7, builds on -O3 and enables further optimizations breaking strict standards compliance. When specified in CFLAGS, these were always overridden by -O0 or -O2. Fix this by adding them to flags_opt_all. Ref: https://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Optimize-Options.html Ref: curl#1404 (comment) Closes curl#1440
Member
Author
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Og, introduced in GCC 4.8, optimizes for debugging experience. Whenspecified in
CFLAGS, it was always overridden by-O0or-O2. Fix thisby adding it to flags_opt_all.
Ref: https://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Optimize-Options.html
Ref: #1404 (comment)