Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: detect AppleIDN #14401

Closed
wants to merge 3 commits into from
Closed

configure: detect AppleIDN #14401

wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Aug 5, 2024

Follow-up to add22fe

@bagder bagder added build appleOS specific to an Apple operating system name lookup DNS and related tech labels Aug 5, 2024
@bagder
Copy link
Member Author

bagder commented Aug 5, 2024

The failed Windows CI job is a separate issue: #14403

@bagder bagder closed this in 8de8fe8 Aug 6, 2024
@bagder bagder deleted the bagder/configure-apple-idn branch August 6, 2024 07:36
vszakats added a commit to vszakats/curl that referenced this pull request Aug 6, 2024
@vszakats
GHA/macos: enable AppleIDN in autotools job
b7cc20b 
Follow-up to 8de8fe8 curl#14401
Closes #xxxxx
@vszakats vszakats mentioned this pull request Aug 6, 2024
Closed
vszakats added a commit that referenced this pull request Aug 6, 2024
@vszakats
GHA/macos: enable AppleIDN in autotools job
ada8ebe 
- make `--with-apple-idn` override libidn2, in sync with cmake and
  `lib/curl_setup.h`.

- sync detection function name with cmake.

- limit AppleIDN feature check to Darwin.
  (also drop !WinIDN precondition check.)

Follow-up to 8de8fe8 #14401
Closes #14419
vszakats added a commit that referenced this pull request Aug 13, 2024
@vszakats
GHA/macos: disable AppleIDN for autotools in combinations jobs
d76389d 
Without libidn2, AppleIDN gets enabled by default in autotools.

To remain minimal and match cmake.

Follow-up to 8de8fe8 #14401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
appleOS specific to an Apple operating system build name lookup DNS and related tech
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bagder