-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cipher options documentation #14407
Conversation
e525e3d
to
927b830
Compare
res = curl_easy_perform(curl); | ||
curl_easy_cleanup(curl); | ||
} | ||
} | ||
~~~ | ||
|
||
# HISTORY | ||
|
||
Added in 7.52.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to mention "added in", because that is inserted automatically in the %AVAILABILITY%
section so this ends up repeated info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-review updated updated content.
|
||
For OpenSSL, wolfSSL, mbedTLS, Secure Transport and BearSSL a valid example | ||
of a cipher list is: | ||
**ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we maybe insert spaces after the colons or something to break this very long line? To make it more readable in the rendered outputs (man page or curl -M).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I tried another approach. But it is a bit like shoving a maxi-single through a letterbox.
I just did #14543 that solves the problem with long example lines in the output. |
Try rebasing this on master now and force-pushing and I believe it should do better |
Rebased and added changes for #14535. |
Thanks! |
No description provided.