Skip to content

Improve cipher options documentation - #14407

Closed
jan2000 wants to merge 1 commit into
curl:masterfrom
jan2000:doc-ciphers
Closed

Improve cipher options documentation#14407
jan2000 wants to merge 1 commit into
curl:masterfrom
jan2000:doc-ciphers

Conversation

@jan2000

@jan2000 jan2000 commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@jan2000
jan2000 marked this pull request as draft August 5, 2024 23:07
@jan2000
jan2000 force-pushed the doc-ciphers branch 2 times, most recently from e525e3d to 927b830 Compare August 6, 2024 00:10
@jan2000
jan2000 marked this pull request as ready for review August 6, 2024 00:53
@jan2000 jan2000 mentioned this pull request Aug 6, 2024
Closed
bagder
bagder reviewed Aug 7, 2024
View reviewed changes
Comment thread docs/libcurl/opts/CURLOPT_PROXY_SSL_CIPHER_LIST.md Outdated

@bagder bagder Aug 6, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to mention "added in", because that is inserted automatically in the %AVAILABILITY% section so this ends up repeated info.

@jan2000 jan2000 Aug 8, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-review updated updated content.

Comment thread docs/libcurl/opts/CURLOPT_PROXY_SSL_CIPHER_LIST.md Outdated

@bagder bagder Aug 7, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe insert spaces after the colons or something to break this very long line? To make it more readable in the rendered outputs (man page or curl -M).

@jan2000 jan2000 Aug 8, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I tried another approach. But it is a bit like shoving a maxi-single through a letterbox.

Comment thread docs/libcurl/opts/CURLOPT_SSL_CIPHER_LIST.md Outdated
Comment thread docs/cmdline-opts/tls13-ciphers.md Outdated
Comment thread docs/cmdline-opts/proxy-ciphers.md Outdated
Comment thread docs/cmdline-opts/proxy-tls13-ciphers.md Outdated
@jan2000
jan2000 marked this pull request as draft August 8, 2024 15:29
@github-actions github-actions Bot added the tests label Aug 8, 2024
@jan2000
jan2000 marked this pull request as ready for review August 8, 2024 16:06
@jan2000 jan2000 mentioned this pull request Aug 13, 2024
Closed
@bagder

bagder commented Aug 14, 2024

Copy link
Copy Markdown
Member

I just did #14543 that solves the problem with long example lines in the output.

@bagder

bagder commented Aug 16, 2024

Copy link
Copy Markdown
Member

Try rebasing this on master now and force-pushing and I believe it should do better

@jan2000

jan2000 commented Aug 16, 2024

Copy link
Copy Markdown
Contributor Author

Rebased and added changes for #14535.

@bagder bagder closed this in 88727f7 Aug 17, 2024
@bagder

bagder commented Aug 17, 2024

Copy link
Copy Markdown
Member

Thanks!

@jan2000 jan2000 mentioned this pull request Aug 17, 2024
Closed
@jan2000
jan2000 deleted the doc-ciphers branch August 19, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

cmdline tool documentation libcurl API tests

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jan2000 @bagder