Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtests: if DISABLED cannot be read, error out #14411

Closed
wants to merge 2 commits into from
Closed

runtests: if DISABLED cannot be read, error out #14411

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Aug 6, 2024

No description provided.

@bagder bagder added the tests label Aug 6, 2024
@github-actions github-actions bot added the script label Aug 6, 2024
@bagder

This comment was marked as outdated.

Sign in to view
@bagder

This comment was marked as outdated.

Sign in to view
@bagder bagder force-pushed the bagder/exit-on-non-DISABLED branch 2 times, most recently from 12c8c9d to fdae780 Compare August 6, 2024 12:46
@bagder bagder force-pushed the bagder/exit-on-non-DISABLED branch from fdae780 to 7116bf0 Compare August 6, 2024 13:13
@bagder bagder linked an issue Aug 6, 2024 that may be closed by this pull request
CI jobs with WinIDN enabled still run tests disabled for WinIDN #14403
Closed
@bagder bagder closed this in b0394b1 Aug 6, 2024
bagder added a commit that referenced this pull request Aug 6, 2024
@bagder
tests/runner: only allow [!A-Za-z0-9_-] in %if feature names
48818a4 
... in the %if preprocessor parser.

This guards against accidentally getting a carriage-return part of the
feature name.

Fixes #14403
Closes #14411
@bagder bagder deleted the bagder/exit-on-non-DISABLED branch August 25, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelRaad MarcelRaad MarcelRaad approved these changes

Assignees
No one assigned
Labels
script tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI jobs with WinIDN enabled still run tests disabled for WinIDN
2 participants
@bagder @MarcelRaad