cmake: cleanup header paths #14416
Closed
cmake: cleanup header paths #14416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no generated include header and this directory is either missing in out-of-tree builds or the same as the one already added globally via the root `CMakeLists.txt`.
It's already added globally from the root `CMakeLists.txt`.
Which is the header actually used and also referred to from autotools.
Besides syncing with autotools, this also prevents out-of-tree builds breaking due to leftover generated headers in the source tree.
Example do not and should not use internal headers.
vszakats
changed the title
vszakats
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync build-dir/source-dir header path order with autotools, by
including build-dir first, then source-dir.
This prevents out-of-tree builds breaking due to leftover generated
headers in the source tree.
tests/unit: move
srcahead oflibtestin header path, syncing withautotools.
stop adding non-existing generated
includedir to header path.There are no generated
includeheaders and this directory is eithermissing in out-of-tree builds or the same as the one already added
globally via the root
CMakeLists.txt.lib: stop adding a duplicate source include directory to the header
path.
It's already added globally via the root
CMakeLists.txt.lib: stop adding the project root to the header path.
docs/examples: drop internal header paths.
Examples do not and should not use internal headers.
replace
curl_setup_once.hin comments withcurl_setup.h,the header actually used, and also referred to in autotools comments.
add comment why we need
srcin include path fortests/server.add quotes around header directories.
Closes #14416