Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manpage: ensure a maximum width for the text version #14423

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Aug 6, 2024

... using the new script 'maxline' to which we specify the maximum number of columns we allow any single line to be, or it will cause an error.

Bonus: shorten the long line in the --ipfs-gateway section.

@jan2000
Copy link
Contributor

jan2000 commented Aug 6, 2024

So, I was already wondering about the line limit yesterday, because I have this long line in PR #14407:

For OpenSSL, wolfSSL, mbedTLS, Secure Transport and BearSSL a valid example
of a cipher list is:
**ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305**

(Which I really want to keep this way because these four ciphers are the equivalent of the two ciphers in the TLS1.3 example.)

What to do with this then?

@bagder
Copy link
Member Author

bagder commented Aug 6, 2024

Either we come up with a shorter example, or we figure out a way how to split it into multiple lines.

@bagder
Copy link
Member Author

bagder commented Aug 6, 2024

Also, the current limit is set to 100 columns but that's a bit arbitrary. We can tweak it if we think we should.

The most important thing is that code in src/tool_help.c has an array size that is larger than the longest line, so I want this to make sure this is true.

@dfandrich
Copy link
Contributor

Analysis of PR #14423:

Test 1026 failed,
which has NOT been flaky recently,
so there could be a real issue in the PR.
Note that this test has failed in 6
different CI jobs (the link just goes to one of them).

Test 216 failed,
which has NOT been flaky recently,
so there could be a real issue in the PR.
Note that this CI job has had a number of other flaky tests recently
(2, to be exact) so it may be that this failure
is rather a systemic issue with this job and not with this specific PR.

Test 340 failed,
which has NOT been flaky recently,
so there could be a real issue in the PR.

Test 165 failed,
but it has been permanently failing lately,
so it's probably NOT a fault of the PR.

Generated by Testclutch

... using the new script 'maxline' to which we specify the maximum
number of columns we allow any single line to be, or it will cause an
error.

Starting out with a max width at 100 columns.

Bonus: shorten the long line in the --ipfs-gateway section.

Closes #14423
@bagder bagder closed this in badbd4e Aug 8, 2024
@bagder bagder deleted the bagder/maxline branch August 8, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants