idn: align AppleIDN behaviour with libidn2 #14431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns the behaviour with libidn2 and the curl documentation.
UIDNA API returns two error values but we were only checking one. Checking both better aligns the behaviour with that of libidn2.
bagder
approved these changes
Aug 7, 2024
bagder
pushed a commit
that referenced
this pull request
Aug 7, 2024
UIDNA API returns two error values but we were only checking one. Checking both better aligns the behaviour with that of libidn2. Closes #14431
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libcurl documentation states:
AppleIDN was following the Windows behaviour of only using UTF-8. We can however use
iconvhere, which is shipped with macOS, to convert to UTF-8 and align the behaviour with libidn2.This also in turn fixes test 1034 as the input is validated as a part of character encoding conversion.
uidna_nameToASCII_UTF8returns two error values. One largely covers fatal errors and other bad inputs, which we were currently checking. However there was a second error value that validates whether the output IDNA is valid to the spec.Checking this better aligns the behaviour with that of libidn2 and fixes test 1035.
Ref: #14176