Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krb5: add Linux/macOS CI tests, fix cmake GSS detection #14447

Closed
wants to merge 5 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Aug 7, 2024

  • GHA/macos: enable GSS krb5 in a cmake job.
    Uses CMake-native detection.

  • GHA/linux: enable GSS krb5 in autotools job and add a cmake job to match.
    CMake uses pkg-config-based detection.

  • GHA/linux: add step to dump configure logs.

  • fix and simplify logic digesting FindGSS output.

  • cmake: add heimdal-gssapi to libcurl.pc.

Closes #14447

@vszakats vszakats added authentication CI Continuous Integration labels Aug 7, 2024
@vszakats vszakats marked this pull request as draft August 7, 2024 18:40
@vszakats vszakats force-pushed the gha-krb5 branch 2 times, most recently from 845c467 to a1d6496 Compare August 7, 2024 22:15
@vszakats vszakats changed the title GHA: test krb5 on Linux and macOS krb5: add Linux/macOS CI tests, fix cmake GSS detection Aug 7, 2024
@vszakats vszakats added the cmake label Aug 7, 2024
Fixing:
```
/usr/bin/cc  -I/home/runner/openssl3/include -I/usr/include/mit-krb5 -pedantic-errors
[...] -Wpragmas -Wunused-const-variable
-isystem;/usr/include/mit-krb5 -isystem /usr/include/mit-krb5
-L/usr/lib/x86_64-linux-gnu/mit-krb5 -lgssapi_krb5 -L"/usr/lib/x86_64-linux-gnu/mit-krb5"
-o CMakeFiles/cmTC_d77e1.dir/HAVE_SYS_FILIO_H.c.o
-c /home/runner/work/curl/curl/CMakeFiles/CMakeScratch/TryCompile-uKwCBN/HAVE_SYS_FILIO_H.c
        cc: error: missing path after ‘-isystem’
        cc: fatal error: no input files
```
Ref: https://github.com/curl/curl/actions/runs/10290950517/job/28482155390#step:31:1226
@vszakats vszakats marked this pull request as ready for review August 7, 2024 22:30
@vszakats vszakats closed this in d3f6b2f Aug 8, 2024
@vszakats vszakats deleted the gha-krb5 branch August 8, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication CI Continuous Integration cmake
Development

Successfully merging this pull request may close these issues.

1 participant