Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtests: log ignored but passed tests #14457

Closed
wants to merge 2 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Aug 8, 2024

List tests explicitly ignored, but passing. It can be useful to catch
ignore rules that are no longer necessary because the tests are not
failing anymore.

To not clutter the default view, hide this information under a GitHub
Actions foldable group.

Closes #14457

@vszakats vszakats marked this pull request as draft August 8, 2024 12:43
@vszakats vszakats added the tests label Aug 8, 2024
@github-actions github-actions bot added the script label Aug 8, 2024
@vszakats vszakats changed the title runtests: try to show ignored but passed tests runtests: show ignored but passed tests Aug 8, 2024
@vszakats
Copy link
Member Author

vszakats commented Aug 8, 2024

It's quite a bit of lines when ignoring by keywords like ~FTP, so I'm worried this is too verbose. Though the goal would be not have anything (unnecessarily) ignored, so ideally these lines should converge to zero.

@vszakats vszakats marked this pull request as ready for review August 12, 2024 15:37
@vszakats vszakats changed the title runtests: show ignored but passed tests runtests: log ignored but passed tests Aug 13, 2024
@vszakats vszakats closed this in 1a444e3 Aug 13, 2024
@vszakats vszakats deleted the tests-show-ignored-passed branch August 13, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant