Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Replace nonportable grep -o with awk #14469

Closed
wants to merge 1 commit into from

Conversation

dfandrich
Copy link
Contributor

This stops an error shown at the end of configure on systems with POSIX
grep and fixes the warning it's trying to convey.

Closes #14469

@github-actions github-actions bot added the build label Aug 9, 2024
dfandrich added a commit that referenced this pull request Aug 9, 2024
This stops an error shown at the end of configure on systems with POSIX
grep and fixes the warning it's trying to convey.

Closes #14469
@dfandrich
Copy link
Contributor Author

This is only the second use of awk in the curl build path. Since awk is not installed by default everywhere any longer, someone may wish to convert these to something else to make building ever so slightly simpler for people, at the risk of complicating the resulting code.

@dfandrich
Copy link
Contributor Author

Actually, it seems that autoconf itself uses awk internally in many places making it a hard dependency, so there's no real point in trying to remove curl's explicit use of it.

@bagder bagder changed the title Replace nonportable grep -o with awk configure: Replace nonportable grep -o with awk Aug 9, 2024
@dfandrich
Copy link
Contributor Author

Analysis of PR #14469:

Test 1379 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Note that this CI job has had a number of other flaky tests recently (2, to be exact) so it may be that this failure is rather a systemic issue with this job and not with this specific PR.

Generated by Testclutch

@dfandrich
Copy link
Contributor Author

Test failure is the usual FTP server glitch. In any case, it's completely unrelated to the PR.

@dfandrich
Copy link
Contributor Author

autoconf ate my brackets. Trying again.

This stops an error shown at the end of configure on systems with POSIX
grep and fixes the warning it's trying to convey.

Closes #14469
@dfandrich dfandrich closed this in e48d882 Aug 9, 2024
@dfandrich dfandrich deleted the dfandrich/grepo branch August 9, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants