Skip to content

docs: add description of effect of --location-trusted on cookie - #14471

Closed
XYenon wants to merge 1 commit into
curl:masterfrom
XYenon:master
Closed

docs: add description of effect of --location-trusted on cookie#14471
XYenon wants to merge 1 commit into
curl:masterfrom
XYenon:master

Conversation

@XYenon

@XYenon XYenon commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

No description provided.

bagder
bagder reviewed Aug 9, 2024
View reviewed changes

@bagder bagder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is indeed details we should clarify!

Comment thread docs/cmdline-opts/location-trusted.md Outdated
Comment thread docs/cmdline-opts/location-trusted.md Outdated
Comment thread docs/cmdline-opts/location.md Outdated

@bagder bagder Aug 9, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to clarify the cookie use. Because normally cookies are only sent to the correct host names so this extra precaution is only for when you "force" cookies explicitly.

@XYenon XYenon Aug 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this description now?

bagder added a commit that referenced this pull request Aug 9, 2024
@bagder
libcurl/docs: expand on redirect following and secrets to other hosts
c829c07 
For CURLOPT_FOLLOWLOCATION and CURLOPT_UNRESTRICTED_AUTH

Ref: #14471
@bagder bagder mentioned this pull request Aug 9, 2024
Closed
bagder added a commit that referenced this pull request Aug 12, 2024
@bagder
libcurl/docs: expand on redirect following and secrets to other hosts
6f00a05 
For CURLOPT_FOLLOWLOCATION and CURLOPT_UNRESTRICTED_AUTH

Ref: #14471
Closes #14472
bagder
bagder requested changes Aug 12, 2024
View reviewed changes

@bagder bagder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned

@XYenon
XYenon requested a review from bagder August 15, 2024 02:52
@bagder

bagder commented Aug 17, 2024

Copy link
Copy Markdown
Member

Please also fix the "badwords" error:

docs/cmdline-opts/location-trusted.md:24:9: error: found bad word "host name\b"
   24 | more of host name, protocol scheme or port number changed.
      |         ^~~~~~~~~~~
 maybe use "hostname" instead?

bagder
bagder requested changes Aug 17, 2024
View reviewed changes

@bagder bagder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment

XYenon
XYenon commented Aug 17, 2024
View reviewed changes
Comment thread docs/cmdline-opts/location-trusted.md Outdated
@XYenon
XYenon requested a review from bagder August 17, 2024 14:05
@bagder bagder closed this in 5fcf969 Aug 17, 2024
@bagder

bagder commented Aug 17, 2024

Copy link
Copy Markdown
Member

Thanks!

Joshix-1
Joshix-1 reviewed Aug 17, 2024
View reviewed changes
Comment thread docs/cmdline-opts/location.md
bagder added a commit that referenced this pull request Aug 17, 2024
@bagder
location: fix typo
47a4864 
Follow-up to 5fcf969
Bug: #14471 (review)
Reported-by: Joshix-1 on github
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes
+1 more reviewer
@Joshix-1 Joshix-1 Joshix-1 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cmdline tool documentation HTTP

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XYenon @bagder @Joshix-1