Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add description of effect of --location-trusted on cookie #14471

Closed
wants to merge 1 commit into from

Conversation

XYenon
Copy link
Contributor

@XYenon XYenon commented Aug 9, 2024

No description provided.

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is indeed details we should clarify!

docs/cmdline-opts/location-trusted.md Outdated Show resolved Hide resolved
docs/cmdline-opts/location-trusted.md Outdated Show resolved Hide resolved
When authentication or cookie is used, curl only sends its credentials to the
initial host. If a redirect takes curl to a different host, it does not get the
user+password or cookie pass on. See also --location-trusted on how to change
this.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to clarify the cookie use. Because normally cookies are only sent to the correct host names so this extra precaution is only for when you "force" cookies explicitly.

Copy link
Contributor Author

@XYenon XYenon Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this description now?

bagder added a commit that referenced this pull request Aug 9, 2024
For CURLOPT_FOLLOWLOCATION and CURLOPT_UNRESTRICTED_AUTH

Ref: #14471
bagder added a commit that referenced this pull request Aug 12, 2024
For CURLOPT_FOLLOWLOCATION and CURLOPT_UNRESTRICTED_AUTH

Ref: #14471
Closes #14472
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned

@XYenon XYenon force-pushed the master branch 3 times, most recently from d08db47 to a27f996 Compare August 13, 2024 03:43
@XYenon XYenon requested a review from bagder August 15, 2024 02:52
@bagder
Copy link
Member

bagder commented Aug 17, 2024

Please also fix the "badwords" error:

docs/cmdline-opts/location-trusted.md:24:9: error: found bad word "host name\b"
   24 | more of host name, protocol scheme or port number changed.
      |         ^~~~~~~~~~~
 maybe use "hostname" instead?

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment

@bagder bagder closed this in 5fcf969 Aug 17, 2024
@bagder
Copy link
Member

bagder commented Aug 17, 2024

Thanks!

bagder added a commit that referenced this pull request Aug 17, 2024
Follow-up to 5fcf969
Bug: #14471 (review)
Reported-by: Joshix-1 on github
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants