multi: make the "general" list of easy handles a Curl_llist #14474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having an especially "unique" linked list handler for the main list of easy handles within the multi handle, this now uses a regular Curl_llist for this as well. With this change, it is also clearer that every easy handle added to a multi handle belongs to one and only one out of three different lists: process - the general one for normal transfer processing pending - queued up waiting to get a connection (MSTATE_PENDING) msgsent - transfer completed (MSTATE_MSGSENT) An easy handle must therefore be removed from the current list before it gets added to another. Closes #14474
bagder
force-pushed
the
bagder/multi-process
branch
from
809d4a0 to
ec125b8
Compare
Aearsis
added a commit
to Aearsis/curl
that referenced
this pull request
May 5, 2025
The split of lists for easy handles introduced in curl#14474 introduced a bug that not all handles were returned from `curl_multi_get_handles`, skipping the ones residing in pending and msgsent lists. This commit fixes it - maybe simplistically, but it works and is similar to `curl_multi_get_handle`. Closes #TODO
Aearsis
added a commit
to Aearsis/curl
that referenced
this pull request
May 5, 2025
The split of lists for easy handles introduced in curl#14474 introduced a bug that not all handles were returned from `curl_multi_get_handles`, skipping the ones residing in pending and msgsent lists. This commit fixes it - maybe simplistically, but it works and is similar to `curl_multi_get_handle`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having an especially "unique" linked list handler for the main list of easy handles within the multi handle, this now uses a regular Curl_llist for this as well.
With this change, it is clearer that every easy handle added to a multi handle belongs to one and only one out of three different lists:
process - the general one for normal transfer processing
pending - queued up waiting to get a connection (MSTATE_PENDING)
msgsent - transfer completed (MSTATE_MSGSENT)