llist: remove direct struct accesses, use access functions #14485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
added a commit
that referenced
this pull request
Aug 11, 2024
Curl_llist_head() return the first node in a linked list. Curl_list_elem() returns the data associated with a linked list node. Curl_list_next() returns the next node entry in the list. The llist related structs got all their fields renamed in order to make sure no existing code remains using direct access. Add docs/LLIST.md documenting the internal linked list API. Closes #14485
bagder
force-pushed
the
bagder/llist-abstract
branch
from
7d78a79
to
6062c4e
Compare
bagder
added a commit
that referenced
this pull request
Aug 11, 2024
Turned them all into functions to also do asserts etc. The llist related structs got all their fields renamed in order to make sure no existing code remains using direct access. Rename the node struct and some of the access functions. Add docs/LLIST.md documenting the internal linked list API. Closes #14485
bagder
force-pushed
the
bagder/llist-abstract
branch
from
6062c4e
to
eb69dba
Compare
bagder
added a commit
that referenced
this pull request
Aug 11, 2024
- Turned them all into functions to also do asserts etc. - The llist related structs got all their fields renamed in order to make sure no existing code remains using direct access. - Rename the node struct and some of the access functions. - Added lots of ASSERTs to verify API being used correctly - Fix some cases of API misuse Add docs/LLIST.md documenting the internal linked list API. Closes #14485
bagder
force-pushed
the
bagder/llist-abstract
branch
from
a594a4c
to
ff8845d
Compare
bagder
added a commit
that referenced
this pull request
Aug 11, 2024
- Turned them all into functions to also do asserts etc. - The llist related structs got all their fields renamed in order to make sure no existing code remains using direct access. - Rename the node struct and some of the access functions. - Added lots of ASSERTs to verify API being used correctly - Fix some cases of API misuse Add docs/LLIST.md documenting the internal linked list API. Closes #14485
bagder
force-pushed
the
bagder/llist-abstract
branch
from
4347fdc
to
1b5ae06
Compare
- Turned them all into functions to also do asserts etc. - The llist related structs got all their fields renamed in order to make sure no existing code remains using direct access. - Rename the node struct and some of the access functions. - Added lots of ASSERTs to verify API being used correctly - Fix some cases of API misuse Add docs/LLIST.md documenting the internal linked list API. Closes #14485
bagder
force-pushed
the
bagder/llist-abstract
branch
from
e139014
to
b8a42a1
Compare
Store a pointer to the list in each node
Since it now operates with node input argument only
Introduce Curl_node_uremove() for passing in a non-NULL user pointer
|
I consider myself fairly done with this PR now and aim at merging this once the CI jobs are green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docs/LLIST.md documenting the internal linked list API.