hash: provide asserts to verify API use #14503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bagder
commented
Aug 12, 2024
•
bagder
commented
- converted the Curl_hash_count() macro to a function
- Discourage accessing struct fields directly
- Document the API
bagder
force-pushed
the
bagder/hash-asserts
branch
from
7e4a0ec to
ddabd73
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bagder
force-pushed
the
bagder/hash-asserts
branch
2 times, most recently
from
5dc87b2 to
270450f
Compare
- converted the Curl_hash_count() macro to a function - Discourage accessing struct fields directly - Document the internal API in HASH.md Closes #14503
bagder
force-pushed
the
bagder/hash-asserts
branch
from
6f55d10 to
7ea1698
Compare
and add some asserts while at it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.