mime client reader, avoid infinite loop #14532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
vszakats
changed the title
|
scanbuild seems to have an opinion here! |
I hate compilers that warn about "unnecessary inits". 🤮 |
Curl_mime_read() may go into an infinite loop when called with buffer lengths <= 4. Some encoders, like base64, are not prepared for that. In the client reader for mime data, skip such small reads. The upload buffers will get flushed eventually and larger reads will happen again. Improves robustness of test652 which triggered the loop on blocked sends.
icing
force-pushed
the
mime-read-avoid-infinity
branch
from
a73e452
to
f6c7d49
Compare
|
Rebased and removed the init line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curl_mime_read() may go into an infinite loop when called with buffer lengths <= 4. Some encoders, like base64, are not prepared for that.
In the client reader for mime data, skip such small reads. The upload buffers will get flushed eventually and larger reads will happen again.
Improves robustness of test652 which triggered the loop on blocked sends.
Refs #14527.