cmake: fix and tidy up c-ares builds, enable in more CI jobs #14541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
vszakats
changed the title
vszakats
force-pushed
the
cm-ares-tests
branch
2 times, most recently
from
ea7479f to
830836e
Compare
It fails on this platform, despite linking statically. Ref: 96a1a05 curl#14096
472: fails with mingw with Unicode enabled. 1299, 1613: seem like a case of expanding '*' to a filename. ``` FAIL 472: 'aws-sigv4 with query' HTTP, aws-sigv4 FAIL 1299: 'Send "OPTIONS *" with --request-target' HTTP, --request-target FAIL 1613: 'Send "OPTIONS *" with --request-target to a proxy' HTTP, HTTP proxy, --request-target ``` Ref: https://github.com/curl/curl/actions/runs/10388126947/job/28765761441#step:15:5902
vszakats
force-pushed
the
cm-ares-tests
branch
from
830836e to
1601535
Compare
vszakats
added a commit
that referenced
this pull request
Feb 10, 2025
Extend output filter to pick up backslashes. This makes them pass in CI when run in the vcpkg MSVC job, for example. Also: - cmake: allow TrackMemory, aka `ENABLE_CURLDEBUG` again. Drop FIXME. - cmake: drop stale TODO. - runtests: include the word 'TrackMemory' in the message disabling it. Follow-up to 9f23c8f #14541 Follow-up to 94c596b #16283 Closes #16289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set
CARES_NO_DEPRECATEDto avoid c-ares deprecation warnings.Like autotools does.
drop unused c-ares header directory when building libtests and test
servers.
disable TrackMemory (aka
CURLDEBUG) feature for MSVC builds.It fails on test 558 and 1330, saying that TrackMemory isn't working.
Left a FIXME about it.
GHA/macos: enable c-ares in a cmake job.
GHA/windows: enable c-ares in MSVC job.
Fixes GHA/windows: add MSVC c-ares to openssl job #14202
GHA/windows: add c-ares mingw autotools job with tests.
(move
--with-windows-unicodeoption from 'default' job tothis one to keep the former "default".)
Put these tests on ignore for now:
Ref: https://github.com/curl/curl/actions/runs/10388126947/job/28765761441#step:15:5902
472: fails with mingw despite Unicode enabled.
1299, 1613: seem like a case of expanding '*' to a filename.
GHA/windows: enable c-ares in mingw cmake job.