Repository navigation
Conversation
vszakats
force-pushed
the
cm-find-var-casing
branch
from
August 16, 2024 22:46
8e01ca1 to
96860bb
Compare
vszakats
force-pushed
the
cm-find-var-casing
branch
from
August 17, 2024 08:42
96860bb to
bc4f9d4
Compare
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Aug 17, 2024
vszakats
added a commit
that referenced
this pull request
Sep 28, 2026
If you use these variables, replace them like so: - `MBEDTLS_INCLUDE_DIRS` -> `MBEDTLS_INCLUDE_DIR` - `WolfSSL_INCLUDE_DIR` -> `WOLFSSL_INCLUDE_DIR` - `WolfSSL_LIBRARY` -> `WOLFSSL_LIBRARY` - `Zstd_INCLUDE_DIR` -> `ZSTD_INCLUDE_DIR` - `Zstd_LIBRARY` -> `ZSTD_LIBRARY` They were deprecated two years ago in curl 8.10.0. Follow-up to 9fbda4c #14574 Follow-up to db39c66 #14542 Closes #23139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To match with other config variables and other projects.
Rename these CMake configuration variables:
WolfSSL_INCLUDE_DIR->WOLFSSL_INCLUDE_DIRWolfSSL_LIBRARY->WOLFSSL_LIBRARYZstd_INCLUDE_DIR->ZSTD_INCLUDE_DIRZstd_LIBRARY->ZSTD_LIBRARYThe old values continue to work, with a warning suggesting the new name.
Also:
PC_Zstd_*to uppercase.Follow-up to db39c66 #14542