Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
cmake: Add CURL_CA_BUNDLE/CURL_CA_FALLBACK/CURL_CA_PATH #1461
Looks good to me except one thing.
Do I understand correctly that this a matter of taste with no impact on the behaviour of the script?
Whenever possible, I'd prefer a general solution over a platform specific solution to avoid extra complexity that comes with case distinctions. When we set a bunch of possible paths, that do not exist on Windows, fine. But why not add a Windows path into the mix? The current code would allow that (but as you said, there is no such path).
One thing that is let's me tent to a general solution is that "being on Windows" is not a black or white question. With Cygwin and MinGW in the mix, we need to support systems that are more or less like Windows, which makes feature testing much easier than OS distinctions. When you search the Internet for
As far as I can see, there is no harm in finding and using given paths on a Windows-like system with a Unix-like file system.
Paxxi left a comment
I think you're right. I generally try to avoid checks not needed on the platform out of habit.
To make sure I did test this PR on Windows now and the tests doesn't generate any message/warnings/errors so should be perfectly fine as is.