Repository navigation
Conversation
- `lib/curl_printf.h` undefined a macro that was not redefined, nor used in the source. Delete it. - `lib/curlx.h` undefined a macro that was not redefined. Map it to its `curlx_m*` counterpart.
bagder
reviewed
Aug 21, 2024
| # define mvsnprintf curlx_mvsnprintf | ||
| # define aprintf curlx_maprintf | ||
| # define vaprintf curlx_mvaprintf | ||
| # define vsprintf curlx_mvsprintf |
Member
There was a problem hiding this comment.
No need to add this define. This function should not be used in libcurl code.
Member
Author
There was a problem hiding this comment.
OK, then # undef vsprintf can be safely deleted few lines above, isn't it?
Member
There was a problem hiding this comment.
Yes, it seems to serve no purpose.
vszakats
changed the title
vsnprintf, vsprintf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop #undefining macros that were not redefined or used in the code.