Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Libs.private improvements #14668

Closed
wants to merge 8 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Aug 23, 2024

  • skip adding pkg-config libdirs if they are system locations.
  • replace custom regexes with get_filename_component().
  • collect -L and -framework separately.
    It means these will appear before libs in the Libs.private entry,
    syncing it with ./configure.
  • collect in a list variable (was: string).
  • use list(REMOVE_DUPLICATES) to deduplicate libdirs.
  • rename internal variable that is now solely used for system libdirs.

Follow-up to 7c0b6eb #14652


@vszakats
Copy link
Member Author

/cc @levitte Would you mind taking a look?

@vszakats vszakats changed the title cmake: update Libs.private generation cmake: Libs.private improvements Aug 24, 2024
@vszakats vszakats closed this in c96551c Aug 26, 2024
@vszakats vszakats deleted the cm-libdir-exclude-sysdir branch August 26, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant