Skip to content

cmake: Libs.private improvements - #14668

Closed
vszakats wants to merge 8 commits into
curl:masterfrom
vszakats:cm-libdir-exclude-sysdir
Closed

vszakats wants to merge 8 commits into
curl:masterfrom
vszakats:cm-libdir-exclude-sysdir

Conversation

@vszakats

@vszakats vszakats commented Aug 23, 2024 •

Copy link
Copy Markdown
Member
  • skip adding pkg-config libdirs if they are system locations.
  • replace custom regexes with get_filename_component().
  • collect -L and -framework separately.
    It means these will appear before libs in the Libs.private entry,
    syncing it with ./configure.
  • collect in a list variable (was: string).
  • use list(REMOVE_DUPLICATES) to deduplicate libdirs.
  • rename internal variable that is now solely used for system libdirs.

Follow-up to 7c0b6eb #14652


@vszakats

Copy link
Copy Markdown
Member Author

/cc @levitte Would you mind taking a look?

@vszakats
vszakats force-pushed the cm-libdir-exclude-sysdir branch from a864dfb to a53b02e Compare August 24, 2024 16:27
@vszakats vszakats changed the title cmake: update Libs.private generation cmake: Libs.private improvements Aug 24, 2024
@vszakats
vszakats force-pushed the cm-libdir-exclude-sysdir branch from a53b02e to 0df01d7 Compare August 26, 2024 10:13
@vszakats vszakats closed this in c96551c Aug 26, 2024
@vszakats
vszakats deleted the cm-libdir-exclude-sysdir branch August 26, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant