cmake: delete unused NEED_LBER_H, HAVE_LDAP_H - #14690
Closed
vszakats wants to merge 7 commits into
Closed
Conversation
vszakats
marked this pull request as draft
August 26, 2024 12:06
vszakats
changed the title
HAVE_LDAP_H (C macro) and NEED_LBER_HNEED_LBER_H
vszakats
force-pushed
the
del-NEED_LBER_H
branch
from
August 26, 2024 13:16
9849e4d to
c412ae3
Compare
vszakats
changed the title
NEED_LBER_HNEED_LBER_H, HAVE_LDAP_H
vszakats
marked this pull request as ready for review
August 26, 2024 14:37
Member
Author
|
|
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Both are used by `./configure` internally, not by curl C code. CMake adds `NEED_LBER_H` to `CURL_TEST_DEFINES`, which is used by `curl_internal_test()`, but there is no LDAP-related test made with that call. Thus, stop detecting and publishing these from CMake. `NEED_LBER_H` added in 7320e53. `HAVE_LDAP_H` added in 4c5307b (initial CMake commit). Closes curl#14690
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both are used by
./configureinternally, not by curl C code.CMake adds
NEED_LBER_HtoCURL_TEST_DEFINES, which is used bycurl_internal_test(), but there is no LDAP-related test made with thatcall.
Thus, stop detecting and publishing these from CMake.
NEED_LBER_Hadded in 7320e53.HAVE_LDAP_Hadded in 4c5307b (initial CMake commit).